Closed Bug 220915 Opened 21 years ago Closed 20 years ago

cookie site list was suddenly empty; cookie list was not affected .

Categories

(Core :: Networking: Cookies, defect)

x86
Windows 98
defect
Not set
normal

Tracking

()

VERIFIED FIXED

People

(Reporter: spurred_on, Assigned: neil)

Details

Attachments

(1 file)

User-Agent:       Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.5) Gecko/20030925
Build Identifier: Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.5) Gecko/20030925

Using Mozilla 1.5 beta I opened the Cookie Manager to delete a cookie. While
there I checked my Cookie Site list, which I do periodically, and found the list
completely empty.

Afterwards, new cookie sites I either allowed or disallowed cookies from were
duly listed.

When I installed Mozilla 1.5 release candidate 2, suddenly my old cookie site
list was restored. Although I had thought the original lest had been deleted,
apparantly it was not. Rather, Mozilla either could not find the list or could
not read it.

Reproducible: Didn't try

Steps to Reproduce:
1.I have no idea how to reproduce the problem.
2.
3.

Actual Results:  
Upon installation of new Mozilla release, the problem was resolved. However,
because I do not know what caused the p[roblem, I do not know if it will recur.

Expected Results:  
As the list was intact, Mozilla should have been able to find and read the list.
There have been fixes to reading in the cookie permission list between 1.5b and
rc1. So that can be the cause of what you saw.
Summary: cookie site list was suddenly empty; cookie list was not affected . → cookie site list was suddenly empty; cookie list was not affected .
*** Bug 233063 has been marked as a duplicate of this bug. ***
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7a) Gecko/20040202

Confirmed similar behavior in recent build:

1.  Open Cookie Manager
2.  Select checkbox for "Don't allow sites that set removed cookies to set
future cookies"
3.  Delete a cookie

You will find that the newly-deleted cookie disappears from the "Stored Cookies"
tab but does *not* appear in the "Cookie Sites" tab until you close and reopen
the Cookie Manager window.  At that time it properly shows up with "site cannot
set cookies" status.

Similary, but harder to duplicate, if you delete a larger number of cookies
(i.e. select a group of cookies and hit "Remove Site" or 'Delete' key) you will
sometimes see *only* these deleted cookies in the "Cookie Sites" tab, and all
other cookies appear to have disappeared.  When you close/open Cookie Manager
everything is back to normal.
dwitte, could this be a regression from your notifications-fu?
possible, but i doubt it...

neil, if you have some spare cycles, some quick debugging would be really
appreciated ;)

i'll try to look at this sometime
(more likely a CookieViewer.js bug)
OK, so the issue with the deleted cookie permissions not showing up is a
regression from my batch update fix - although the cookie list gets updated the
permission list needs to be manually updated if updating the cookie list sets a
permission. Or I could make the batch update only apply to the current list.
Attached patch Proposed patchSplinter Review
OK, so this makes the batch flag the tree being updated.
Assignee: darin → neil.parkwaycc.co.uk
Status: UNCONFIRMED → ASSIGNED
Attachment #140855 - Flags: review?(dwitte)
Comment on attachment 140855 [details] [diff] [review]
Proposed patch

nice! r=me
Attachment #140855 - Flags: review?(dwitte) → review+
Attachment #140855 - Flags: superreview?(darin)
Attachment #140855 - Flags: superreview?(darin) → superreview+
Fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Tony: does this still happen? If not, please mark as verified.
Since installing the release version of 1.5 I have repeatedly accesed and
modified my stored cookies list and cookie site (permissions) list. So far, the
permissions list has remained complete. As this system is about to be wiped and
converted to a server, I have not installed the latest build of Mozilla on it.
Therefore, I do not know if the problem is still present in 1.6 versions.
However, from all that has been written above, I will mark this bug as Verified.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: