220975 - [altss] Style sheet selector does not display "No Theme" for pages without a base stylesheet (but shows Basic Theme)

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[David P James]

For pages having alternate stylesheets but where there is no base stylesheet
(eg, a lack of a stylesheet without a title attribute), the style sheet selector
does not display 'No Theme' but instead only displays 'Basic Theme' along with
the titles of the other themes on that page. This is incorrect - such pages do
not have a base or basic theme/style to speak of. Moreover, selecting 'Basic
Theme' does what 'No Theme' usually does - completely strips all styling from
the page, whereas on pages with both 'No Theme' and 'Basic Theme' the latter
just strips the styling of the alternate stylesheets but not that of the
untitled base theme.

At present, Asa's blog is an example of such a page. I'm also going to attach a
pair of test cases.

Comment 1

[David P James]

Attachment: 'Day' stylesheet for forthcoming testcase

Comment 2

[David P James]

Attachment: 'Night' stylesheet for forthcoming testcase

Comment 3

[alanjstr]

Broken Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.5) Gecko/20030925
Firebird/0.7

Comment 4

[David P James]

Attachment: Test case without 'No Theme' but with alternate stylesheets

This test case is like Asa's blog. 'Basic Theme' in fact displays 'No Theme'.

Comment 5

[David P James]

Attachment: Base style for counter testcase

Comment 6

[David P James]

Attachment: Test case with a specified base theme - doesn't show the bug

Last one, I promise. This is how most pages with alternate stylesheets appear,
where selecting Basic strips the alternate styling but not the base styling.

Comment 7

[Jeremy M. Dolan]

Encountered this myself working on my page. CSS sheet naming and interactions
are confusing enough without the browser misleading users and developers.

Comment 8

[Jeremy M. Dolan]

dupe-proofing with what I was searching for before I resorted to regexps.

Comment 9

[alanjstr]

Bug still there 
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7) Gecko/20040614 Firefox/0.9

Comment 10

[James Graham]

I have a fix for this bug (I think), but I have the impression that there has
been some discussion of {changing|removing} the alternate stylesheets UI in
firefox prior to 1.0. Any pointers to that discussion would be much appreciated.
I feel strongly that this UI is needed in some form and I have more ideas for
improvements that I'd like to make. However there seems little point in going to
the effort of looking for reviews if the feature dies in the next week.

Comment 11

[u81239]

James: bug 253722

Fixing this bug will probably help in keeping the functionality.

Comment 12

[fantasai]

Seems to have been fixed by check-in for bug 253332. Let me know if it's still a
problem.