221012 - nsGNOMERegistry must not call gnome_program_init when embedded

Status: RESOLVED FIXED

(Core Graveyard :: Embedding: GTK Widget, defect)

Description

[Christian Persch (GNOME) (away; not receiving bug mail)]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.0.1) Gecko/20020823 Netscape/7.0
Build Identifier: 

When embedding mozilla in Epiphany, gnome_program_init is run twice; first from
Epiphany, and a second time from nsGNOMERegistry::Startup(), which sets the
application name to "Gecko".


Reproducible: Always

Steps to Reproduce:




From nsGNOMERegistry::Startup():

  // Initialize GNOME, if it's not already initialized.  It's not
  // necessary to tell GNOME about our actual command line arguments.

  char *argv[1] = { "gecko" };
  _gnome_program_init("Gecko", "1.0", _libgnome_module_info_get(),
                      1, argv, NULL);

Despite the comment, gnome_program_init is called unconditionally.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Bryner, this is yours too.

Comment 2

[Christopher Blizzard (:blizzard)]

This is a pretty serious problem.  I'm not sure how to fix it. 
gnome_program_init() does all sorts of things.

Comment 3

[Brian Ryner (not reading)]

Hm, my understanding from looking at how gnome_program_init works led me to
believe it wouldn't do that if the program was already initialized.

At any rate, we can fix this fairly easily.  Patch coming up.

Comment 4

[Brian Ryner (not reading)]

Attachment: suggested fix

check whether gnome_program_get() returns null; only call gnome_program_init()
if it does

Comment 5

[Brian Ryner (not reading)]

checked in.