221288 - XUL tree builder abuses tree batching

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[[e-mail]]

The XUL template builder starts a batch, discards its existing content, creates
new content, notifies the frame of the new content, and ends the batch.

Unfortunately since the frame is not notified that the existing content was
discarded it is unable to correctly update the selection.

The template builder could either send the correct notification, or simply clear
its selection directly, since that would have the same effect.

Steps to reproduce problem:
1. Open History
2. Group by Day
3. Group by None
By this time the current row will be some unrealistically large number.

Comment 1

[[e-mail]]

Attachment: Proposed patch

Comment 2

[Jan Varga [:janv]]

I think this would be more correct:

PRInt32 count = mRows.Count();
mRows.Clear();                                                              
mConflictSet.Clear();                                                          
if (mBoxObject) {
  mBoxObject->BeginUpdateBatch();
  mBoxObject->RowCountChanged(0, -count);
}

Comment 3

[[e-mail]]

Attachment: Jan's approach

As if it makes any difference to the tree...

Comment 4

[Jan Varga [:janv]]

Comment on attachment 132730 [details] [diff] [review]
Jan's approach

r=varga
yes, it makes sense, since RowCountChanged() expects that rows are really
cleared in this case

Comment 5

[[e-mail]]

Comment on attachment 132730 [details] [diff] [review]
Jan's approach

Actually RowCountChanged() doesn't expect anything during a batch :-P

Comment 6

[Alec Flett]

Comment on attachment 132728 [details] [diff] [review]
Proposed patch

hey, if varga agrees, then I agree :) sr=alecf

Comment 7

[Jan Varga [:janv]]

Yeah, but that should be internal to the tree widget implementation.

Comment 8

[[e-mail]]

Comment on attachment 132730 [details] [diff] [review]
Jan's approach

alecf: sorry, but jan insists on doing things the hard way (I say :-P to him)

Comment 9

[Alec Flett]

Comment on attachment 132730 [details] [diff] [review]
Jan's approach

heh, ok. sr=alecf

Comment 10

[[e-mail]]

Fix checked in.