22133 - Recent gtk widget changes broke build for commercial compilers

Status: VERIFIED FIXED

(Core :: XUL, defect, P3)

Description

[tor]

I'm seeing these problems on SUNWspro 4.2, but most likely other commercial
C++ compilers are breaking the same way.  A patch is attached; the first bit
for nsDragService.h adds "static" to the method which is passed to GTK as
a callback.  The second bit for nsGtkEventHandler.cpp essentially backs out
pavlov's latest changes, as NS_STATIC_CAST was causing problems when
NS_RELEASE tried to assign the resulting casted pointer a zero value.
The casted pointer is not an lvalue, as even g++ will admit if you pass
it "-pedantic".

Comment 1

[tor]

Attachment: Patch described in bug report

Comment 2

[Stuart Parmenter]

reassigning to me.  this patch works.  my compiler was getting confused about
which addref and release to use so i added the static casts, but it no longer
seems to be confused...  so i'm confused.. heh  but other than that, the patch
looks good.  emailing chofmann to see if i can check it in.

Comment 3

[Stuart Parmenter]

checked in patch

Comment 4

[Paul MacQuiddy]

[e-mail] please verify, thanks

Comment 5

[tor]

Fix is in, SUNWspro is happy.