221643 - regression: escape sequences in pref name not handled correctly

Status: RESOLVED FIXED

(Core :: Preferences: Backend, defect, P1)

Description

[Darin Fisher]

pref regression with '\\' path delimiters, see bug 209110 comment #15:

>------- Additional Comment #15 From Jacek R. aka Yano  2003-10-08 03:30 -------
>
>On network printer path is the same:
>user_pref("print.printer_\\TREE\\printer-queue.print_bgimages", false);
>after next run is changed to:
>user_pref("print.printer_\\\\TREE\\\\printer-queue.print_bgimages", false);
>After few days my prefs.js had 23 megabytes of this junk!!!

Comment 1

[Darin Fisher]

Attachment: v1 patch

add code to handle escape sequences found in the pref name.  this patch just
leverages the code that was already there to handle escape sequences found in a
pref string value.

Comment 2

[Brendan Eich [:brendan]]

Comment on attachment 132946 [details] [diff] [review]
v1 patch

>+        /* string escape sequence parsing */
>+        case PREF_PARSE_ESC_STRING:
>+            /* not necessary to resize buffer here since we are only
>+             * writing one character and the resize check would have
>+             * been done for us in the PREF_PARSE_STRING_VALUE state. */

"writing only" not "only writing", and shouldn't the last line refer to
PREF_PARSE_NAME or PREF_PARSE_VALUE, not PREF_PARSE_STRING_VALUE?

sr=[e-mail] with comment fixage.

/be

Comment 3

[Darin Fisher]

Attachment: v1.1 patch

revised patch with comment tweaks per brendan's review.

Comment 4

[timeless]

Comment on attachment 132972 [details] [diff] [review]
v1.1 patch

r=me, noting sr=brendan

Comment 5

[Darin Fisher]

fixed-on-trunk w/ r=timeless

Comment 6

[[e-mail]]

Comment on attachment 132972 [details] [diff] [review]
v1.1 patch

It seems that the following comment isn't quite true, although I for one won't
lose any sleep over it ;-)

>+            /* not necessary to resize buffer here since we are writing
>+             * only one character and the resize check would have been
>+             * done for us in the previous state. */
>+            switch (c) {
...
>+            default:
>+                NS_WARNING("preserving unexpected JS escape sequence");
>+                *ps->lbcur++ = '\\'; /* preserve the escape sequence */
>+                break;
>+            }
>+            *ps->lbcur++ = c;