221768 - Static Build with MinGW GCC 3.3.1 Problem

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect)

Description

[Hilary]

User-Agent:       Mozilla/5.0 (Windows; U; Win 9x 4.90; en-US; rv:1.6a) Gecko/20031009 Firebird/0.7+ (hilary gcc mingw 3.3.1 static build)
Build Identifier: Mozilla/5.0 (Windows; U; Win 9x 4.90; en-US; rv:1.6a) Gecko/20031009 Firebird/0.7+

When building Firebird in the static mode, makefile will include the library
twice for certain library. e.g.

gcc -o helloworld.exe libjs3230.a --whole-archive libjs3230.a --no-whole-archive

Gcc will complain duplicate declarion error. I have modifed the rules.mk to
remove the duplicated libraries.

Another problem is final-link-libs and final-link-comps. the Makefile script
cannot build a correct list of libraries' name into it. final-link-comps miss
texteditor_s.


Reproducible: Always

Steps to Reproduce:
1.
2.
3.




Index: rules.mk
===================================================================
RCS file: /cvsroot/mozilla/config/rules.mk,v
retrieving revision 3.418
diff -u -r3.418 rules.mk
--- rules.mk	18 Sep 2003 17:24:54 -0000	3.418
+++ rules.mk	10 Oct 2003 06:55:48 -0000
@@ -1021,7 +1021,7 @@
 	@for lib in $(SHARED_LIBRARY_LIBS); do $(AR_EXTRACT) $${lib}; $(CLEANUP2); done
 endif # SHARED_LIBRARY_LIBS
 endif # NO_LD_ARCHIVE_FLAGS
-	$(MKSHLIB) $(SHLIB_LDSTARTFILE) $(OBJS) $(LOBJS) $(SUB_SHLOBJS) $(RESFILE)
$(LDFLAGS) $(EXTRA_DSO_LDOPTS) $(OS_LIBS) $(EXTRA_LIBS) $(DEF_FILE)
$(SHLIB_LDENDFILE)
+	$(MKSHLIB) $(SHLIB_LDSTARTFILE) $(OBJS) $(SUB_SHLOBJS) $(RESFILE) $(LDFLAGS)
$(EXTRA_DSO_LDOPTS) $(OS_LIBS) $(EXTRA_LIBS) $(DEF_FILE) $(SHLIB_LDENDFILE)
 	@rm -f foodummyfilefoo $(SUB_SHLOBJS)
 else # os2 vacpp
 	$(MKSHLIB) /O:$@ /DLL /INC:_dllentry $(LDFLAGS) $(OBJS) $(LOBJS)
$(EXTRA_DSO_LDOPTS) $(OS_LIBS) $(EXTRA_LIBS) $(DEF_FILE)

Comment 1

[Hilary]

Attachment: Patch the rules.mak to remove duplicated library

Comment 2

[Vedran Miletic]

Reporter: you should request review/super-review on patch to get it reviewed by
developers.

Comment 3

[cls]

Not Fire* specific.

Comment 4

[cls]

Attachment: v1.0

An incorrect assumption was made when generating the link line when using
SHARED_LIBRARY_LIBS.  We have a bare OS check to indicate that we want to
accomodate MSVC's linker's behavior but we also need to check that we're not
building with gcc which uses a different linker with different behavior.

Comment 5

[Benjamin Smedberg]

Comment on attachment 141667 [details] [diff] [review]
v1.0

looks ok to me, but I'd like mkaply to make sure this is right for OS/2 also.

Comment 6

[jhp (no longer active)]

cls, I hope I'm reading this right, but I think this won't work for OS/2, since
we now use GCC, but with our own linker;  so for OS/2, we still want to go down
that path, even with GNU_CC defined.  Unfortunately, I'm struggling to come up
with a _single_ line that would accomodate what we want.

Comment 7

[cls]

Does it break if you replace the $(GNU_CC)$(GNU_CXX) with $(GNU_LD) ?

Comment 8

[jhp (no longer active)]

That should work.  For OS/2, we have GNU_CC and GNU_CXX set to 1, but GNU_LD is
unset.  I'll test this out later today.

Comment 9

[cls]

Attachment: v1.1

Check GNU_LD instead of GNU_CC || GNU_CXX

Comment 10

[cls]

Patch has been checked in.