Closed
Bug 221826
Opened 22 years ago
Closed 22 years ago
only create stack objects in Cut if they'll be used
Categories
(Core :: XPCOM, enhancement)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
People
(Reporter: timeless, Assigned: timeless)
Details
Attachments
(1 file, 1 obsolete file)
|
1.80 KB,
patch
|
dbaron
:
review+
dbaron
:
superreview+
|
Details | Diff | Splinter Review |
Trivial optimization found while investigating something else.
Attachment #133028 -
Flags: superreview?(dbaron)
Attachment #133028 -
Flags: review?(dbaron)
Comment on attachment 133028 [details] [diff] [review]
-uw7 scope variables for use
The bracing/indentation style of this patch does not follow the conventions of
the surrounding code. Other than that, it looks fine, though.
Attachment #133028 -
Flags: superreview?(dbaron)
Attachment #133028 -
Flags: superreview-
Attachment #133028 -
Flags: review?(dbaron)
Attachment #133028 -
Flags: review-
Attachment #133028 -
Attachment is obsolete: true
Comment on attachment 133029 [details] [diff] [review]
-u7 scope variables for use
you're right...
Attachment #133029 -
Flags: superreview?(dbaron)
Attachment #133029 -
Flags: review?(dbaron)
Attachment #133029 -
Flags: superreview?(dbaron)
Attachment #133029 -
Flags: superreview+
Attachment #133029 -
Flags: review?(dbaron)
Attachment #133029 -
Flags: review+
checked in
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
|
||
Updated•5 years ago
|
Component: String → XPCOM
You need to log in
before you can comment on or make changes to this bug.
Description
•