222419 - remove wallet.TutorialFromMenu key from navigator.properties

Status: RESOLVED FIXED

(Core :: Internationalization: Localization, defect)

Description

[Tsahi Asher]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; he-IL; rv:1.4) Gecko/20030624
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; he-IL; rv:1.4) Gecko/20030624

the key wallet.TutorialFromMenu in navigator.properties
(http://lxr.mozilla.org/mozilla/source/xpfe/browser/resources/locale/en-US/navigator.properties#33
) reffers to chrome://communicator/locale/wallet/privacy.html, a file that no
longer exists. the key itself, to the best of my knowledge, is also not used
anymore.

IMHO this key should be removed.


Reproducible: Always

Steps to Reproduce:
1.
2.
3.

Comment 1

[[e-mail]]

care to submit a patch?

Comment 2

[Tsahi Asher]

i didn't install patch maker yet, i guess it's about time.
in the next few days i'll be busy with the hebrew language pack for mozilla 1.5
i'm making, can you or someone else do it?

Comment 3

[Stephen Donner [:stephend] Not actively reading bugmail]

It was 'fun' tracking the changes down:

bug 72402 has http://bugzilla.mozilla.org/attachment.cgi?id=28039&action=view,
which removed, among other things in pref-cookies.xul:

-  function viewTutorial() 
-  {
-    window.openDialog
-     
("chrome://communicator/content/wallet/privacy.xul","","modal=yes,chrome,resizable=yes,height=400,width=600",
0);
-  }  
- 

The current function looks like:

 41   function init()
 42   {
 43     parent.initPanel('chrome://cookie/content/pref-cookies.xul');
 44     setDisables(false);
 45 
 46     const NS_COOKIECONSENT_CONTRACTID = '@mozilla.org/cookie-consent;1';
 47     if (NS_COOKIECONSENT_CONTRACTID in Components.classes) {
 48       var p3pRadioButton = document.getElementById("p3pRadioButton");
 49       p3pRadioButton.removeAttribute("hidden");
 50     }

As for what LXR says of the wallet.Tutorial*:

http://lxr.mozilla.org/seamonkey/search?string=wallet.Tutorial

/modules/libpref/src/init/all.js, line 658 -- pref("wallet.TutorialFromMenu",
"chrome://navigator/locale/navigator.properties");

/xpfe/browser/resources/locale/en-US/navigator.properties, line 33 --
wallet.TutorialFromMenu=chrome://communicator/locale/wallet/privacy.html

So no XUL uses it...

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Patch

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

-> me.

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

-> me.

Comment 7

[[e-mail]]

Comment on attachment 133487 [details] [diff] [review]
Patch

Actually this was made redundant by bug 149357.

Comment 8

[Stephen Donner [:stephend] Not actively reading bugmail]

Fixed.