223290 - Account Settings dialog should come to front when it is already open

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Account Configuration, defect)

Description

[Stefan Borggraefe]

Steps to reproduce:
1. Open two MailNews windows
2. Select "Edit|Mail & Newsgroups Account Settings" in window 1
3. Change to window 2
4. Select "Edit|Mail & Newsgroups Account Settings" in window 2

Result:
Nothing happens.

Expected result:
Bring the already open Account Settings dialog to front.

Comment 1

[Stefan Borggraefe]

Attachment: Patch

Comment 2

[Stefan Borggraefe]

Comment on attachment 139112 [details] [diff] [review]
Patch

timeless, could you review? Thanks!

Comment 3

[David :Bienvenu]

Comment on attachment 139112 [details] [diff] [review]
Patch

+	 if (server)
+	     existingAccountManager.selectServer(server, null);

I'm not sure about this part - if the existing account manager window already
had a different server selected, I'm not sure that the new request should
clobber that selection. Probably nicer	to just focus it.

Comment 4

[Stefan Borggraefe]

> I'm not sure about this part - if the existing account manager window already
> had a different server selected, I'm not sure that the new request should
> clobber that selection. Probably nicer	to just focus it.

On the other hand when the Account Manager is called via the context menu item
"Properties" from the folder pane, the user might expect to have the account
selected he just clicked on. Also the data entered into the pane that was
selected before is not lost.

I see both the pros and cons, so I'm going to attach a second patch which
behaves like you suggest. Just review the patch you like more. I'm fine with
both solutions.

Comment 5

[Stefan Borggraefe]

Attachment: Just focus the Account Manager

Comment 6

[David :Bienvenu]

Comment on attachment 139579 [details] [diff] [review]
Just focus the Account Manager

I don't feel that strongly either way but I marginally prefer this - not having
the server selected might remind the user that they already had the account
settings up :-)

Comment 7

[Stefan Borggraefe]

Comment on attachment 139579 [details] [diff] [review]
Just focus the Account Manager

timeless: Could you review this small change and check the patch in if it's ok?
Thanks!

Comment 8

[Stefan Borggraefe]

Checked in by timeless. :-)