Closed
Bug 223295
Opened 21 years ago
Closed 20 years ago
<dialog>s don't need trailing <separator>s
Categories
(SeaMonkey :: MailNews: Message Display, defect)
SeaMonkey
MailNews: Message Display
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.7beta
People
(Reporter: neil, Assigned: Stefan.Borggraefe)
Details
Attachments
(1 file)
|
2.45 KB,
patch
|
neil
:
review+
mscott
:
superreview+
|
Details | Diff | Splinter Review |
As per bug 187466 if dialog buttons are too close to dialog content it's a theme issue. However there are still old dialogs out there with trailing separators, I see AccountManager.xul, SmtpServerList.xul, subscribe.xul and FilterEditor.xul; there may be others.
|
Assignee | |
Comment 2•21 years ago
|
||
I searched with find . -name "*.xul" | xargs grep -B 3 \</dialog\> and then investigated the output. This patch removes all trailing separators I found this way.
|
|
Assignee | |
Updated•21 years ago
|
Attachment #134309 -
Flags: superreview?(mscott)
Attachment #134309 -
Flags: review?(neil.parkwaycc.co.uk)
|
|
Assignee | |
Comment 3•21 years ago
|
||
Comment on attachment 134309 [details] [diff] [review] Fix AccountManager.xul is not included in this patch, because it will be fixed by the checkin for bug 222940.
|
Reporter | |
Updated•21 years ago
|
Attachment #134309 -
Flags: review?(neil.parkwaycc.co.uk) → review+
|
||
Updated•21 years ago
|
Attachment #134309 -
Flags: superreview?(mscott) → superreview+
|
|
Assignee | |
Comment 4•21 years ago
|
||
Scott, this bug needs someone with CVS write access to TB. Could you check this in? Thanks!
OS: Windows 2000 → All
Hardware: PC → All
|
|
||
Comment 5•20 years ago
|
||
I just checked this in
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.7beta
|
||
Updated•20 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•