Closed Bug 223336 Opened 21 years ago Closed 21 years ago

Cannot perform search from sidebar

Categories

(SeaMonkey :: Sidebar, defect)

x86
Windows XP
defect
Not set
major

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: ted, Assigned: timeless)

Details

(Keywords: regression)

Attachments

(1 file)

User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6a) Gecko/20031022 Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6a) Gecko/20031022 when opening the sidebar and its search tab, the search button beside the search text window is ghosted, i.e. not active, not allowing a search to be performed via the sidebar. this is true regardless of search engine chosen, and whether a search string is typed or not. Reproducible: Always Steps to Reproduce: 1.open sidebar 2.enter text in search window 3. Actual Results: search button is ghosted / unable to search Expected Results: search button should be active default theme used
Confirming. Works on previous nightlies, but not on today's nightly (2003102204/WIN XP), search from sidebar does not work.
Severity: normal → major
Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: regression
Summary: search button ghosted in sidebar → Cannot perform search from sidebar
http://lxr.mozilla.org/mozilla/source/xpfe/components/search/resources/search-panel.js#130 has an erroneous RegExp (there are 2 more occurences). /+/g should be /\+/g , or it will throw a SyntaxError since the check-in for bug 85721. See bug 223273, comment 10.
Attached patch per zach-wegSplinter Review
Attachment #134060 - Flags: superreview?(bzbarsky)
Attachment #134060 - Flags: review?(neil.parkwaycc.co.uk)
Comment on attachment 134060 [details] [diff] [review] per zach-weg sr=bzbarsky
Attachment #134060 - Flags: superreview?(bzbarsky) → superreview+
Attachment #134060 - Flags: superreview?(bzbarsky)
Attachment #134060 - Flags: superreview+
Attachment #134060 - Flags: review?(neil.parkwaycc.co.uk)
Attachment #134060 - Flags: review+
Attachment #134060 - Flags: superreview?(bzbarsky) → superreview+
Flags: blocking1.6a?
Comment on attachment 134060 [details] [diff] [review] per zach-weg a=asa (on behalf of drivers) for checkin to 1.6alpha
Attachment #134060 - Flags: approval1.6a+
Who can land this. Time is running out for 1.6a.
sorry, no one was actually cc'd to this bug.
Assignee: sidebar → timeless
checked in
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Thanks, timeless.
Flags: blocking1.6a?
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: