223390 - "Save as" and "Save Link as…" save gzipped content when server uses gzip content-encoding

Status: VERIFIED FIXED

(Toolkit :: Downloads API, defect)

Description

[Kelley Cook]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.5) Gecko/20031007 MozillaFirebird/0.7
Build Identifier: http://ftp.mozilla.org/pub/mozilla.org/firebird/nightly/2003-10-22-08-trunk/MozillaFirebird-win32.zip

Right clicking on a link and choosing "Save link as…" (at least on link which
points to a text/plain file on an http site) no longer works correctly on Firebird.

The last milestone Win32 build in the firebird directory which is the October
7th 0.7 build does work as did every version of Mozilla I've ever used. So it is
a recent bug.

Reproducible: Always

Steps to Reproduce:
   1. Go to http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/COPYING.
   2. Right Click on Download; choose "Save Link As ..." and save it anywhere.
   3. Now look at that file, it is binary mess, when it should have just been
nice text.

Actual Results:  
Get a binary mess

Expected Results:  
Got a nice text file describing the GPL copying terms.

Comment 1

[Jesse Ruderman]

The "binary mess" is gzip.  You can tell by renaming the file to .gz and running
gunzip (in cygwin-bash, not in cmd).

Also happens at:
http://216.239.57.104/search?q=cache:wisIv0-Mqv8J:jchat.cyber.sccs.chukyo-u.ac.jp/JCHAT/mailing-list/childes/msg00857.html+motherese&hl=en&ie=UTF-8
http://www.squarefree.com/

Works: Gecko/20031008 Firebird/0.7+ (aebrahim) (bug 221899 was present here!)
Broken: Gecko/20031009 Firebird/0.7+ (aebrahim)
Works: Gecko/20031028
Broken: Gecko/20031103 Firebird/0.7+

Conclusions: This bug was introduced between 10/08 and 10/09, affects only
Firebird, and is still present.

Of checkins between 10/08 and 10/09, I suspect the checkin for bug 152275,
"saved files with GZIP encoding are not ungziped automatically".  Fixing this
bug is probably just a matter of porting the xpfe portion of bug 152275's patch.

Comment 2

[Pierre Chanial]

taking

Comment 3

[Pierre Chanial]

Thanks Jess for this wonderful bug report! :)
Marking fixed, but this all contentAreaUtils.js file needs to be resync'd.

Comment 4

[Pierre Chanial]

Sorry for the typo
s/Jess/Jesse

Comment 5

[Boris Zbarsky [:bzbarsky]]

Note that this is not transfer-encoding but content-encoding.  Neither Mozilla
nor any web servers I can think of really support transfer-encoding.

Comment 6

[Simon Paquet [:sipaq]]

verified.