223530 - null pointer dereference in nsTreeContentView.cpp [@ nsTreeContentView::ContentRemoved ]

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[Stef Walter]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.5a) Gecko/20030728 Mozilla Firebird/0.6.1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.6a) Gecko/20031016 Firebird/0.7+

A crash ocurred due to a null pointer dereference in
nsTreeContentView::ContentRemoved. This occurs after all the content is removed
from a tree XUL element, shortly after it's been hidden. See the patch/stack
trace for details.

Reproducible: Always

Steps to Reproduce:
This was in a large mozilla based application and so duplicating this issue
without the entire batch of code would be difficult. However I've included a
stack trace and a patch which solves the problem.
Actual Results:  
Mozilla crashed.

Expected Results:  
Continued without a crash.

Comment 1

[Stef Walter]

Attachment: Stack trace

Comment 2

[Stef Walter]

Attachment: Patch which fixes the issue

Comment 3

[Olivier Cahagne]

Marking NEW since it has patch & stack, and no dupes afaik.
You should ask for review/superreview (possibly bz or dbaron ?)

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 134029 [details] [diff] [review]
Patch which fixes the issue

Jan, could you review?

Comment 5

[Jan Varga [:janv]]

Comment on attachment 134029 [details] [diff] [review]
Patch which fixes the issue

yeah, this just makes sense

Comment 6

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 134029 [details] [diff] [review]
Patch which fixes the issue

sr=bzbarsky.  Jan, could you check this in, please?  I may not be able to in
the near future...

Comment 7

[Jan Varga [:janv]]

fixed, thanks for the patch Nate!