223551 - Printing produces illegal postscript

Status: RESOLVED FIXED

(Core :: Printing: Output, defect)

Description

[Andreas Lange]

User-Agent:       Mozilla/5.0 (X11; U; SunOS sun4u; en-US; rv:1.6a) Gecko/20031023
Build Identifier: Mozilla/5.0 (X11; U; SunOS sun4u; en-US; rv:1.6a) Gecko/20031023

Suspected regression from bug 80190.

Reproducible: Sometimes

Steps to Reproduce:
1. Open new browser (recently built from cvs head)
2. Print (possbly to file) using postscript output
3.

Actual Results:  
Both ghostview and printer displays an error

Expected Results:  
I got out some pages, seemed lovely. Would hope it did that every time. :)

Current page setup was in landscape, that might have affected. Print preview
worked as it should. Will attach borked postscript file.

Comment 1

[Andreas Lange]

Attachment: Broken postscript generated by printing about:blank (landscape)

Comment 2

[Kenneth Herron]

Confirming. The PS output routines have to temporarily set the numeric locale so
that decimals are printed using periods instead of commas. Some of the functions
are missing these calls, so they're outputting floating-point numbers containing
commas.

I'll attach a patch shortly.

Comment 3

[Kenneth Herron]

-> me

Comment 4

[Kenneth Herron]

Attachment: Set "C" locale in a couple of additional places

Set the locale to "C" while printing the document header and each page header,
to make sure any floating-point numbers are printed with periods instead of
commas.

Comment 5

[Kenneth Herron]

Comment on attachment 134043 [details] [diff] [review]
Set "C" locale in a couple of additional places

This needs to go in before 1.6a is released. Printing is broken for any locale
that doesn't use period for decimals.

Comment 6

[Andreas Lange]

Aha, locale dependant. Good to catch that one. :)

Comment 7

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 134043 [details] [diff] [review]
Set "C" locale in a couple of additional places

sr=bzbarsky (trying to atone for not getting to the other patch fast enough 
;)).

Could this be approved for 1.6a?  Otherwise, all our European users are going
to be very unhappy...

Comment 8

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 134043 [details] [diff] [review]
Set "C" locale in a couple of additional places

Can someone else check this in?

Comment 9

[tor]

Checked in - thanks for finding the problem/fix so fast.