223578 - need to account for new regexp behavior

Status: VERIFIED FIXED

(Other Applications Graveyard :: Venkman JS Debugger, defect)

Description

[Robert Ginda]

The checkin for bug 85721, which fixed bug 123437, changes regexp.match in a way
that breaks venkman.  The same type of changes were required in chatzilla in bug
223247.

Comment 1

[Robert Ginda]

Attachment: patch

Comment 2

[Asa Dotzler [:asa]]

Comment on attachment 134053 [details] [diff] [review]
patch

a=asa (on behalf of drivers) for checkin to 1.6alpha

Comment 3

[Malcolm Rowe]

Anyone planning to land this for 1.6?

Comment 4

[Robert Ginda]

this has already benn checked in

Comment 5

[Malcolm Rowe]

> this has already benn checked in
Not as far as I can see, it hasn't. Am I looking in the wrong place?

For example:
http://bonsai.mozilla.org/cvslog.cgi?
file=mozilla/extensions/venkman/resources/content/command-manager.js
(last checkin May 15, 2003)

Comment 6

[Robert Ginda]

Comment on attachment 134053 [details] [diff] [review]
patch

oops, my bad.  I thought this was the chatzilla version.  Don;t know how I
forgot to check this in.

Comment 7

[Asa Dotzler [:asa]]

Comment on attachment 134053 [details] [diff] [review]
patch

a=asa (on behalf of drivers) for checkin to Mozilla 1.6

Comment 8

[Robert Ginda]

checked in for real this time.

Comment 9

[Robert Ginda]

almost forgot... thanks for the reminder malcolm :)

Comment 10

[Malcolm Rowe]

No problem. Verified fixed per bonsai.