223624 - Miscellaneous compiler warning fixes

Status: RESOLVED FIXED

(NSS :: Libraries, defect, P2)

Description

[Wan-Teh Chang]

I will attach a patch that fixes several compiler warnings.

Comment 1

[Wan-Teh Chang]

Attachment: Patch

1. secutil.c: note->error is a 'long' and should match a %ld format.

2. cmsutil.c: this fprintf statment has two format strings.

3. alg1485.c: the macro MAX is redefined.  Use PR_MAX instead.

4. pk11cert.c: case ecKey is not handled in the switch statement.

5. pk11skey.c: pk11_FindAttrInTemplate is used before it's
declared.

Please review this patch and feel free to check it in for me.

Comment 2

[Nelson Bolyard (seldom reads bugmail)]

It all looks good to me, except the pk11cert.c patch.  I suspect the ec case
needs to do SOMETHING if it's there, but I'll have to look more next week.

Comment 3

[Wan-Teh Chang]

Comment on attachment 134096 [details] [diff] [review]
Patch

Thank you for the code review, Nelson.
I've checked in all the changes in this
patch except for the ecKey change in
pk11cert.c.

Comment 4

[Nelson Bolyard (seldom reads bugmail)]

Comment on attachment 134096 [details] [diff] [review]
Patch

I've looked at the ec patch now.  It's all good.

Comment 5

[Wan-Teh Chang]

I checked in the ecKey patch.  Marked the bug fixed.