223625 - [ps] Printing landscape doesn't work following bug 80190

Status: RESOLVED FIXED

(Core :: Printing: Output, defect)

Description

[Kenneth Herron]

The patch for bug 80190 contains incorrect code for setting up the postscript
coordinate system for landscape mode printing. It contains two problems:

1) The coordinate system is rotated in the wrong direction, resulting in
everything being drawn off the edge of the paper.

2) The coordinate system origin is moved by the width of the printable page at
one point, where it should be moved by the total width of the page including
margins. Ignoring the coordinate rotation error, this results in everything
being half an inch too high on the paper.

Comment 1

[Kenneth Herron]

Attachment: Correct coordinate translation & rotation for landscape mode

The existing code attempts to translate the coordinate origin to the lower
right corner of the page, then rotate the page to make this the lower left
corner. However, it only translates by the printable height, not including
margins, then it rotates in the wrong direction. Note that "height" in this
context is what would normally be the paper width, since we're in landscape
mode.

This patch corrects the translation error by adding in the top & bottom
margins. It also corrects the rotate operation.

Comment 2

[Kenneth Herron]

Attachment: Coordinate system setup for landscape v2

I rooted around a bit and found the code that was supposed to be in the bug
80190 patch. It must have gotten lost somehow.

Anyway, this is a small improvement. The previous patch ended up doing a
translate, a rotate, and another translate when setting up landscape mode. This
just does a rotate and a translate.

When the origin is in the bottom left corner, rotating the page naturally moves
the origin to the top left corner where it's supposed to be. The translate
simply moves the origin from the corner of the paper to the corner of the
printable area.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 134107 [details] [diff] [review]
Coordinate system setup for landscape v2

sr=bzbarsky.  Could we get this regression fix into 1.6a too?

Comment 4

[Asa Dotzler [:asa]]

Comment on attachment 134107 [details] [diff] [review]
Coordinate system setup for landscape v2

a=asa (on behalf of drivers) for checkin to 1.6alpha

Comment 5

[Boris Zbarsky [:bzbarsky]]

Checked in to the trunk for 1.6a.