223728 - view page source and view selection source are broken, xml error displayed instead

Status: VERIFIED FIXED

(Firefox :: General, defect)

Description

[Steffen Wilberg]

View Page Source and View Selection Source is broken; an xml error is displayed
instead.
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6a) Gecko/20031026
Firebird/0.7+ (Steffen)

The reason is that Pierre changed viewSource.xul and viewPartialSource.xul
and introduced these lines: <?xml version="1.0"?>
in this checkin:
http://bonsai.mozilla.org/cvsquery.cgi?date=explicit&mindate=10%2F25%2F2003+20%3A28&maxdate=10%2F25%2F2003+20%3A28

The xml error is:
XML Parsing Error: xml processing instruction not at start of external entity
Location: chrome://global/content/viewSource.xul
Line Number 2, Column 1:
<?xml version="1.0"?>
^

If you remove these lines, it works again.

Comment 1

[Steffen Wilberg]

Attachment: patch

This patch moves the <xml> tag to the top of viewSource.xul and
viewPartialSource.xul. It has to be in the very first line. Another solution
would be to remove the empty line after the # signs but I think this is safer.

Comment 2

[Pierre Chanial]

-> Steffen

Comment 3

[Pierre Chanial]

Thanks for this one too!
marking fixed.

Comment 4

[Simon Paquet [:sipaq]]

verified.