223897 - Cursor navigation for Radio buttons is reversed

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[Stefan Borggraefe]

Steps to reproduce:

1. Focus a radio button, e.g. the second button in
Edit|Preferences|MailNews|Offline|When going online.
2. Press cursor up.

Result:
The radio button *below* the previously focused radio button is selected.

Expected result:
The radio button *above* should be selected.

All other cursor keys show this reversed bahaviour, too.

Comment 1

[[e-mail]]

Attachment: Proposed patch

Plus a teensy bit of cleanup too.

Comment 2

[Stefan Borggraefe]

This was fixed by the checkin for bug 223897.

Neil: Do you want to keep this open for the additional cleanup in your patch?

Comment 3

[[e-mail]]

Once you found the correct bug number you can mark this fixed... the only
changes I have left in my tree are somewhat minor:
* change the code so that when you only have one radiobutton pressing up or down
arrow doesn't fire any events
* change the space key code to check for disabled first (as if the focussed
radio was likely to be disabled :-)
* change the arrow keys not to prevent bubble (they have phase="target")
* make the radio destructor clear the radiogroup cache, so that when you destroy
a document you don't have to remove each radio from the cache, also when you
move a radio you don't remove it from the cache only to clear the cache when you
readd it.

Comment 4

[Stefan Borggraefe]

Ooops, this was the wrong bug number in the clipboard.

This was fixed by the checkin for Bug 226549.

Comment 5

[Stefan Borggraefe]

Comment on attachment 134317 [details] [diff] [review]
Proposed patch

Removing obsolete review request.