223997 - PluginHostImpl should use GetTypeFromURI not FromExtension

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

3962                           nsCOMPtr<nsIURL> url = do_QueryInterface(aURL);
3963                           if(url)
3964                           {

3965 darin           1.365       nsCAutoString extension;
3966                             url->GetFileExtension(extension);

3967 av              1.176     

3968 darin           1.365       if(!extension.IsEmpty())

3969 av              1.176       {
3970                               nsCOMPtr<nsIMIMEService> ms
(do_GetService(NS_MIMESERVICE_CONTRACTID, &res));
3971                               if(NS_SUCCEEDED(res) && ms)
3972                               {

3973 darin           1.365           res =
ms->GetTypeFromExtension(extension.get(), getter_Copies(mt));
[...]

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch

Comment 2

[Peter Lubczynski]

Comment on attachment 134422 [details] [diff] [review]
patch

Just wondering, why is this change needed? I'm guessing just to eliminate
duplicate code? Looks fine, r=peterl

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

yes, that's indeed the reason I did this. (the GetTypeFromURI impl also checks
more stuff than just a qi to nsIURL)

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 134422 [details] [diff] [review]
patch

sr=bzbarsky

Comment 5

[Christian :Biesinger (don't email me, ping me on IRC)]

Checking in modules/plugin/base/src/nsPluginHostImpl.cpp;
/cvsroot/mozilla/modules/plugin/base/src/nsPluginHostImpl.cpp,v  <-- 
nsPluginHostImpl.cpp
new revision: 1.490; previous revision: 1.489
done