224087 - IS_CJ_CHAR should not return true for u > 0xFFEF

Status: RESOLVED FIXED

(Core :: Internationalization, defect)

Description

[timeless]

/Users/timeless/mozilla/content/base/src/nsPlainTextSerializer.cpp:
 In member function `void nsPlainTextSerializer::Write(const nsAString&)':
1761: warning: comparison is always true due to limited range of data type
1761: warning: comparison is always true due to limited range of data type

Comment 1

[Boris Zbarsky [:bzbarsky]]

The problem is the last test in the IS_CJ_CHAR macro:

http://lxr.mozilla.org/seamonkey/source/intl/unicharutil/util/nsUnicharUtils.h#94

Don't we have a bug on that already?  This would be a dup.

Comment 2

[Simon Montagu :smontagu]

I don't think it's a dupe (of bug 223707), because there are two, count 'em, two
versions of the macro, IS_CJ_CHAR and IS_CJK_CHAR. The difference is deliberate:
IS_CJ_CHAR doesn't include Korean characters.

In any case all these macros (and probably their callers) need updating to
Unicode 4.0, but I suggest you just correct the warning for now as in bug 223707.

Comment 3

[timeless]

Attachment: change the limit from 0xFFFF to 0xFFEF

Comment 4

[timeless]

.

Comment 5

[Simon Montagu :smontagu]

Comment on attachment 134403 [details] [diff] [review]
change the limit from 0xFFFF to 0xFFEF

r=smontagu

Comment 6

[timeless]

checked in