224141 - In <metadata.js>, remove unused |function openLink(node)|

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, defect)

Description

[Ian Neal]

As far as I can see the function openLink(node) in metadata.js is no longer used
and could be removed.

Comment 1

[Serge Gautherie (:sgautherie)]

Confirming: <http://lxr.mozilla.org/mozilla/search?string=openLink%28>
{{
openLink(
/browser/base/content/browser-context.inc, line 42 --
oncommand="gContextMenu.openLink();"/>
/browser/base/content/metaData.js, line 376 -- function openLink(node)
/java/plugins/examples/SVG/SVGPlugletFactory.java, line 323 -- public void
openLink(String uri, boolean newc) {
/java/plugins/examples/SVG/SVGPlugletFactory.java, line 327 -- //
application.openLink(uri);
/mail/components/addrbook/content/abCardViewOverlay.js, line 510 -- function
openLink(id)
/mail/components/addrbook/content/addressbook.xul, line 687 -- <html:a
onclick="return openLink('cvHomeWebPage');" href="" id="cvHomeWebPage"/>
/mail/components/addrbook/content/addressbook.xul, line 738 -- <html:a
onclick="return openLink('cvWorkWebPage');" href="" id="cvWorkWebPage"/>
/mailnews/addrbook/resources/content/abCardViewOverlay.js, line 519 -- function
openLink(id)
/mailnews/addrbook/resources/content/abCardViewOverlay.xul, line 96 -- <html:a
onclick="return openLink('cvHomeWebPage');" href="" id="cvHomeWebPage"/>
/mailnews/addrbook/resources/content/abCardViewOverlay.xul, line 153 -- <html:a
onclick="return openLink('cvWorkWebPage');" href="" id="cvWorkWebPage"/>
/mailnews/base/resources/content/mailWindowOverlay.xul, line 724 --
oncommand="gContextMenu.openLink();"/>
/xpfe/browser/resources/content/metadata.js, line 383 -- function openLink(node)
/xpfe/communicator/resources/content/contentAreaContextOverlay.xul, line 77 --
oncommand="gContextMenu.openLink();"/>
}}

Comment 2

[Serge Gautherie (:sgautherie)]

Attachment: (Av1) <metadata.js> [Checked in: Comment 8]

Comment 3

[jag (Peter Annema)]

Comment on attachment 148000 [details] [diff] [review]
(Av1) <metadata.js>
[Checked in: Comment 8]

r+sr=jag

You'll want to at least inform the firefox owners of your intention to remove
this. I doubt they'll object, but ...

Comment 4

[Serge Gautherie (:sgautherie)]

(In reply to comment #3)
> You'll want to at least inform the firefox owners of your intention to remove
> this. I doubt they'll object, but ...

Pierre:
Can you "rs" the FireFox part of this patch ?

Comment 5

[Serge Gautherie (:sgautherie)]

Michael:
Would you have time to process comment 4 ? Thanks.

Comment 6

[Serge Gautherie (:sgautherie)]

(In reply to comment #3)
> You'll want to at least inform the firefox owners of your intention to remove
> this. I doubt they'll object, but ...

IRC:
{{
gautheri	Hello, I'm looking for a rubber-stamp for the FF part of a MAS r+/sr+
trivial patch: https://bugzilla.mozilla.org/show_bug.cgi?id=224141
mconnor_ !?

mconnor_	gautheri: if its part of a treewide patch and has r+sr, its fine,
unless its a UI change
}}

Comment 7

[Mike Connor [:mconnor]]

sure, go for it.

Comment 8

[[e-mail]]

Fix checked in.