Closed Bug 224222 Opened 22 years ago Closed 22 years ago

OK and Cancel buttons are unlabeled/blank; cancel button doesn't work

Categories

(Firefox :: Menus, defect)

Product:
Firefox
Component:
Menus
Platform:
x86
All
Type:
defect
Priority:
Not set
Severity:
blocker

Tracking

()

Status:
VERIFIED FIXED

People

(Reporter: steffen.wilberg, Assigned: p_ch)

References

Details

(Keywords: regression)

Most buttons are unlabeled: Menu File-Page Setup. Menu Bookmarks-Add to bookmarks. Menu Tools-Options. Menu Help-About Mozilla Firebird (2 buttons instead of one). Bookmarks sidebar: Properties, New folder. Alerts (like "The text you entered was not found"). The right button (cancel) doesn't work. This was introduced today (10/30). http://forums.mozillazine.org/viewtopic.php?p=247116#247116 http://forums.mozillazine.org/viewtopic.php?t=32397
My build identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6a) Gecko/20031030 Firebird/0.7+ (Steffen). It was reported to happen with the official builds as well, see the links in comment 0.
Only the OK and Cancel buttons are affected. Other buttons, like in Tools-Options-General or Customize Menu, are not. Find in this page (default button: Find Next) also works.
Summary: most buttons (OK/Cancel/etc.) are unlabeled/blank → OK and Cancel buttons are unlabeled/blank; cancel button doesn't work
This is just a stab in the dark, but looking at the previous day's checkins bug 195093 and bug 126765 seem at least potentially related. Thoughts?
should be fixed but I can't test it atm. There was one missing occurrence of GetApplicationLocale in the patch in bug 195093.
Assignee: blake → p_ch
marking fixed but It would be nice if s.o could verify it.
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
I manually edited the file (dialog.xml) in toolkit.jar, but now the OK and Cancel buttons are gone completely! -> reopening.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
changing summary according to comment 6.
Summary: OK and Cancel buttons are unlabeled/blank; cancel button doesn't work → OK and Cancel buttons are gone (unlabeled/blank before)
*** Bug 224247 has been marked as a duplicate of this bug. ***
Sorry for missing dialog.xml and thanks for fixing it. Anyway, with the change manually made (by editing content.jar), it works for me on Linux (2003-10-30 : build time 07:30 AM US PST) What I did is : unzip toolkit.jar in chrome directory edit dialog.xml use 'jar cvf toolkit.jar content/' to make a new jar file. Just to be sure, I'm buidling firebird now.
Pierre, I just did a distclean followed by a checkout+build, and this fix (that you mentioned in comment #5) appears to have worked. I'm not sure why it's not working for Steffen, but it WFM on Linux (not tested Windows, but I don't see why it wouldn't work).
marking fixed. if the problem persists on Windows, pls reopen it with Windows as OS
Status: REOPENED → RESOLVED
Closed: 22 years ago → 22 years ago
Resolution: --- → FIXED
*** Bug 224257 has been marked as a duplicate of this bug. ***
It's nice that it works with Linux, but I can't get it to work with Windows. I tried the official win32 10/30 nightly with the unlabeled buttons. I replaced dialog.xml in its toolkit.jar with the new version, and the OK and Cancel buttons are gone. I've no luck with my own builds at the moment, please be so kind and and build or modify toolkit.jar yourself on Windows. The cvs path is mozilla/toolkit/content/widgets/dialog.xml. The current version is 1.6. cvs status says my file is up-to-date. It's stored inside toolkit.jar in content/global/widgets. -> reopening for OS: Windows.
Status: RESOLVED → REOPENED
OS: All → Windows XP
Resolution: FIXED → ---
Argh. The cvs version of dialog.xml contains a few #ifdefs that need to be removed before copying the file to toolkit.jar. Now all is fine. Sigh. Marking fixed again and changing summary and OS back to the original. A win32 build without this bug is available here: http://forums.mozillazine.org/viewtopic.php?t=32488 Thanks for fixing and sorry for all the fuss!
Status: REOPENED → RESOLVED
Closed: 22 years ago → 22 years ago
OS: Windows XP → All
Resolution: --- → FIXED
Summary: OK and Cancel buttons are gone (unlabeled/blank before) → OK and Cancel buttons are unlabeled/blank; cancel button doesn't work
*** Bug 224298 has been marked as a duplicate of this bug. ***
*** Bug 224292 has been marked as a duplicate of this bug. ***
*** Bug 224342 has been marked as a duplicate of this bug. ***
*** Bug 224360 has been marked as a duplicate of this bug. ***
*** Bug 224288 has been marked as a duplicate of this bug. ***
*** Bug 225062 has been marked as a duplicate of this bug. ***
verified fixed 2003-11-09
Status: RESOLVED → VERIFIED
QA Contact: bugzilla → menus
You need to log in before you can comment on or make changes to this bug.