224241 - Installation of Sidebars fails

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.6a) Gecko/20031029 Firebird/0.7+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.6a) Gecko/20031029 Firebird/0.7+

Installing a sidebar over the JS-function `window.sidebar.addPanel(...)' results
in an error within the JS-Console and the sidebar isn't installed. 

Installing with the `<a rel="sidebar"...>' link works instead.

Reproducible: Always

Steps to Reproduce:
1. Open specified Page or any other side which installs a sidebar with the
AddPanel function
2. Click link to install


Actual Results:  
Nothing happens and you will find two entries within the JS-Console

Expected Results:  
By selecting the link Firebird should open a window where the destination folder
within the bookmarks can be chosen. 

The function AddPanel is working perfecty with Firebird 0.7. Following nightlies
results in this two errors:

Error 1:
Error: this.window has no properties
Source File: file:///C:/Programme/Firebird_Nightly/components/nsSidebar.js
Line: 108

Error 2:
Error: uncaught exception: [Exception... "'[JavaScript Error: "this.window has
no properties" {file:
"file:///C:/Programme/Firebird_Nightly/components/nsSidebar.js" line: 108}]'
when calling method: [nsISidebar::addPanel]"  nsresult: "0x80570021
(NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "JS frame ::
http://devedge.netscape.com/toolbox/sidebars/ :: addTab :: line 32"  data: yes]

Comment 1

[Simon Paquet [:sipaq]]

Confirming bug with a 20031029 build on WinXP. 0.7-Release works. I will try to
track it down in the next few days.

Comment 2

[Pierre Chanial]

the sidebars on the URL fields can be installed.
I haven't checked with `<a rel="sidebar"...>'. I may have broken that.

Comment 3

[Simon Paquet [:sipaq]]

'<a rel="sidebar"...>'-stuff also works. Thanks Pierre.
Verified fixed on a 2003-11-12 custom-compiled WinXP build.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Thanx, it works also for me now with the actual latest-nightly from 2003-11-12.

Comment 5

[Mike Connor [:mconnor]]

sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs, filter on "beltznerLovesGoats" to get rid of this mass change