224370 - During v1.6a install, license is displayed as a Unix file, instead of a Windows one. (Installed License.txt and Readme.txt have wrong format too.)

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect)

Description

[Serge Gautherie (:sgautherie)]

User-Agent:       Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.6a) Gecko/20031030
Build Identifier: Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.6a) Gecko/20031030

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.6a) Gecko/20031030] (W98SE)

The license display during install is wrong:
like a file with Unix line separators opened with Notepad.


Reproducible: Always

Steps to Reproduce:
1. Start Installer
2. Welcome: Next

Actual Results:  
The license is hardly readable.
(I'll attach a picture.)



[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.5) Gecko/20031007] (W98SE)

v1.5 does it right:
it a regression between v1.5 and v1.6a !

Comment 1

[Serge Gautherie (:sgautherie)]

Attachment: Picture of install license display on W98SE

Comment 2

[Matthias Versen [:Matti]]

Is this new in 1.6a ? 
It could be a cygwin build problem...

Comment 3

[Serge Gautherie (:sgautherie)]

Yes, it IS new in v1.6a !
(and looks very unprofessional :-<)

I have both v1.5 and v1.6a installed.
(I did install CygWin between v1.5 install and v1.6a install, but it's no
concern here, is it ?)

Actually both <license.txt> and <readme.txt>, installed in <?:\Program
Files\mozilla.org\Mozilla> are affected:
opening them with notepad shows that the v1.6a files have unix-like line
separators :-(
Otherwise, the text contents seem to be the same.

NB: May be the Component should be changed from 'Installer' to 'Installer: XPI
Packages' or yet another one ?


[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.6a) Gecko/20031025] (nightly) (W98SE)

If I remember well, this bug did not yet exist in v20031025(04)...

Comment 4

[Benjamin Smedberg]

That's funny, I remember this behavior from a long time ago, and never bothered
with it. Since we use the same license/readme files for all platforms (the
installers, anyway) we probably need to do this using a litte perl substitution.

--BDS

Comment 5

[Daniel (Leaf) Nunes]

This is, in fact, a problem with the system used to do the builds (cygwin
probably being installed with unix-style line endings rather than dos-style).

This will be fixed for beta.

Comment 6

[Daniel (Leaf) Nunes]

I believe i have this fixed in the most recent 1.6a windows builds posted. The
machine will need reconfiguration of cygwin to prevent this from happening with
automated builds in the future, but i don't have time to get to that today.

Comment 7

[Jacek Piskozub]

Verifying fixed with the win32 2003110115 (third build of 1.6a, see bug 224340)
on Windows ME.

Thanks!

Comment 8

[Bill Mason]

*** Bug 226235 has been marked as a duplicate of this bug. ***

Comment 9

[Hermann Schwab]

This regressed again, I assume right after the long pause on building windows
versions, starting with BuildID 2003111309.

Comment 10

[Michael Lefevre]

assuming it's going to be fixed in the same way as it has been previously,
reassigning this...

Comment 11

[Daniel (Leaf) Nunes]

i'll have a more permanent fix in soon.

Comment 12

[Daniel (Leaf) Nunes]

Fixed in the latest creature builds at:
http://ftp.mozilla.org/pub/mozilla.org/mozilla/tinderbox-builds/CREATURE
which means that tomorrow morning's "official" build should be fixed as well.