224450 - print preview toolbar: some buttons broken, some icons missing

Status: VERIFIED FIXED

(Firefox :: Menus, defect)

Description

[Steffen Wilberg]

Print preview toolbar:
broken: Page Setup, switching portrait/landscape, modifying scale
missing icons: arrows, portrait, Landscape

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6a) Gecko/20031102
Firebird/0.7+ (Steffen)

Comment 1

[Steffen Wilberg]

Attachment: restores the icons

It's printPreview.css, not printpreview.css.

Comment 2

[Steffen Wilberg]

Menu File->Page Setup works. Print-Preview->Page Setup doesn't.

Oh, I guess this helps: The functions aren't really broken, but you have to
close print preview and open it again to see the effect, e.g. portrait->landscape.

Comment 3

[Steffen Wilberg]

Attachment: use PrintUtils.showPageSetup() instead of this.doPageSetup()

js console said: doPageSetup is not a function.
The Page Setup dialog works now, but you still have to close print preview and
open it again to see your changes.

Comment 4

[Steffen Wilberg]

Comment on attachment 134641 [details] [diff] [review]
use PrintUtils.showPageSetup() instead of this.doPageSetup()

This was wrong. We want to use the method doPageSetup.
But this.doPageSetup() doesn't work. Maybe just doPageSetup or
parentnode.doPageSetup. Both work, but I don't know which one is correct.

Comment 5

[Steffen Wilberg]

I meant "parentNode" in my last comment.
I don't know how to go on.

Comment 6

[Pierre Chanial]

I prefer this.parentNode.doPageSetup: it unambiguously indicates which routine
it used.
Those buttons don't appear on linux, I planned to test it on windows with a
nightly :)

Comment 7

[Pierre Chanial]

-> Steffen

Comment 8

[Pierre Chanial]

and marking fixed.

Comment 9

[Steffen Wilberg]

Thanks for checking in, Pierre.
But the problem I mentioned in comment 2 remains: The settings don't take effect
until you close and restart print preview. I'm afraid I'm unable to fix that.

Comment 10

[Steffen Wilberg]

CCing Pierre: Please have a look at comment 9.

Comment 11

[Pierre Chanial]

Steffen: I know I screwed the PP: the settings are not really saved. I'll need a
windows nightly to test that. I'll do that tomorrow probably, or the day after.

Comment 12

[Simon Paquet [:sipaq]]

verified fixed 2003-11-09