224500 - Some Customize Headers dialog clean up

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[Stefan Borggraefe]

The Customize Headers dialog is currently cut off when you are using larger
fonts. With my configuration the Ok and Cancel buttons of the dialog are not
reachable. I fixed this bug. While I was at it I also 

- added accesskeys to the dialog
- converted it to <dialog>
- made the dialog resizable. Until now this dialog remembered its size, but
wasn't resizable.

Patch follows...

Comment 1

[Stefan Borggraefe]

Attachment: Patch

Comment 2

[[e-mail]]

Comment on attachment 134671 [details] [diff] [review]
Patch

This window needs extensive conversion if you really want to make it a
dialog... just fix the resizing for now.

Comment 3

[Stefan Borggraefe]

Attachment: New Patch

Removed the conversion from window to dialog.

Comment 4

[[e-mail]]

Comment on attachment 134902 [details] [diff] [review]
New Patch

>+        <label accesskey="&newMsgHeader.accesskey;" control="headerInput">&newMsgHeader.label;</label>
Change this to use value= so that you can see the access key :-)

>+              window.openDialog('chrome://messenger/content/CustomHeaders.xul', "", 'modal,centerscreen,resizable,titlebar,chrome', null);
The centerscreen appears to override the persist="screenX screenY"

Comment 5

[Stefan Borggraefe]

Attachment: Even newer patch

Fixed the <label>. The centerscreen flag and screenX/screenY-persistence work
together like they should (Neil and I tested this again).

Comment 6

[Stefan Borggraefe]

Checked in by timeless. Marking FIXED.