224519 - Label changes on messages are only stored in .msf file and not propagated to mbox file.

Status: VERIFIED FIXED

(MailNews Core :: Database, defect)

Description

[:aceman]

User-Agent:       Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.5) Gecko/20031007 Firebird/0.7
Build Identifier: Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.5) Gecko/20031007 Firebird/0.7

Any change you do on message labels is not kept if the mail index file is
rebuilt. (POP3)

Reproducible: Always

Steps to Reproduce:
1.Label a message
2.Look into the mbox file holding it - there is no change in the
X-MozillaStatus2 header
3.Close Mozilla and delete the appropiate msf file.
4.Restart Mozilla and view the message.
Actual Results:  
Label is lost.

Expected Results:  
Label should be kept even when rebuilding the msf.

Comment 1

[:aceman]

This report is against 1.5. I think this is a regression, because it worked in
1.3 (except that I couldn't set a label to None).

Adding some possible dependencies. There are many more bugs reporting lost labels.

Are bug 107432 and bug 123110 really fixed?

Comment 2

[Christian Eyrich]

*** Bug 226818 has been marked as a duplicate of this bug. ***

Comment 3

[David :Bienvenu]

Attachment: proposed fix

the file pos for the second status line was incorrect - I think the code was
assuming that write updated the file pos, but it didn't...

Comment 4

[David :Bienvenu]

we should definitely fix this for 1.6b/1.6

Comment 5

[Christian Eyrich]

Erm, this patch results in something written out on the X-Mozilla-Status2-line.
But it's not what it should be.

Label  value should   value is
1      0x02000000     0x02000000
2      0x04000000     0x06000000
3      0x06000000     0x06000000
4      0x08000000     0x0E000000
5      0x0A000000     0x0E000000

And if a value is set, it can be set to a higher, but not lower value.

Comment 6

[David :Bienvenu]

from what you're saying, the previous label is not getting cleared - that would
be a different bug.

Comment 7

[Christian Eyrich]

Supposably yes, I wanted to say it just in case.

Comment 8

[David :Bienvenu]

Attachment: patch including fix for problem Christian noted

no, it's good you did. The problem was that we weren't clearing the old label.
This fixes that.

Comment 9

[(not reading, please use [e-mail] instead)]

Comment on attachment 136375 [details] [diff] [review]
patch including fix for problem Christian noted

r/a=sspitzer for 1.6b

Comment 10

[David :Bienvenu]

fixed

Comment 11

[David :Bienvenu]

*** Bug 209164 has been marked as a duplicate of this bug. ***

Comment 12

[David :Bienvenu]

*** Bug 165903 has been marked as a duplicate of this bug. ***

Comment 13

[:aceman]

Thanks for the fix.
As I can only test final versions, I will reopen or confirm the fix after 1.6 is
out. I will leave it FIXED till then.

Comment 14

[David :Bienvenu]

*** Bug 218982 has been marked as a duplicate of this bug. ***

Comment 15

[Timothy VanderWall]

I mistakenly reopened 224519 with the following comment.  Sorry.

After I had Mozilla 1.6a installed for about a week, the label markings
disappeared again from my Inbox.  It was my understanding that this was
corrected in 1.6a, but maybe I am mistaken.  This bug should not be closed.

Comment 16

[David :Bienvenu]

*** Bug 209164 has been marked as a duplicate of this bug. ***

Comment 17

[David :Bienvenu]

no, this is fixed in 1.6b, not 1.6a

Comment 18

[Christian Hamacher]

*** Bug 228028 has been marked as a duplicate of this bug. ***

Comment 19

[:aceman]

Fix verified, thanks David.