224657 - errors in pref-advanced.xul when @mozilla.org/oji/jvm-config-mgr;1 or @mozilla.org/system-preference-service;1 are unavailable

Status: RESOLVED FIXED

(Core Graveyard :: Java: OJI, defect)

Description

[timeless]

chrome://communicator/content/pref/pref-advanced.xul line 197:
Components.classes['@mozilla.org/oji/jvm-config-mgr;1'] has no properties
chrome://communicator/content/pref/pref-advanced.xul line 140: reference to
undefined property Components.classes['@mozilla.org/system-preference-service;1']

Comment 1

[timeless]

chrome://communicator/content/pref/pref-advanced.xul line 222: reference to
undefined property navigator.mimeTypes['application/x-java-vm']

Comment 2

[timeless]

Attachment: look before you leap

Comment 3

[[e-mail]]

Comment on attachment 134748 [details] [diff] [review]
look before you leap

@@ -137,15 +137,14 @@

>+        frame.setAttribute("hidden", "false");
I'm not a fan of copying and pasting someone else's errors;
1. We don't set hidden="false"
2. We've got a property we can use, instead of an attribute
3. Unhidden is the default for this frame

@@ -189,31 +188,30 @@

>+    var jvmConfigMgr;
Hmm... this is only used by getJVMConfigList...

@@ -221,17 +219,17 @@

>+        var result = "";
Move this to the start of the function, and return it at the end?

Comment 4

[timeless]

Attachment: look before you leap with style

jvmConfigMgr is used by some other functions...

Comment 5

[[e-mail]]

Comment on attachment 134792 [details] [diff] [review]
look before you leap with style

Tested on linux and mingw.

Comment 6

[timeless]

checked in

Comment 7

[Pete Zha]

Comment on attachment 134792 [details] [diff] [review]
look before you leap with style

>+      if ("application/x-java-vm" in navigator.mimeTypes)
This line will always be false even there is a java-vm mime type. Who know why?
Because of this problem, the JVM config list is broken when lookup current JVm
selection. Can we remove this line?