Closed
Bug 224732
Opened 21 years ago
Closed 20 years ago
<key modifiers="undefined"/>
Categories
(Other Applications Graveyard :: Venkman JS Debugger, defect)
Other Applications Graveyard
Venkman JS Debugger
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: neil, Assigned: rginda)
Details
Attachments
(1 file)
|
965 bytes,
patch
|
rginda
:
review+
|
Details | Diff | Splinter Review |
If you look in for example the Debug menu you'll see all the unmodified accelerator keys have a + at the beginning, because the key element has modifiers="undefined" set on it when it shouldn't. Side issue: context menus shouldn't display accelerator keys (bug 81563).
|
||
Comment 1•20 years ago
|
||
I had to fix this while working on ChatZilla 0.9.64a, just needs a condition on http://lxr.mozilla.org/mozilla/source/extensions/venkman/resources/content/command-manager.js#270 of (ary[1]).
|
|
||
Comment 2•20 years ago
|
||
|
|
||
Updated•20 years ago
|
Attachment #150500 -
Flags: review?(rginda)
|
Assignee | |
Comment 3•20 years ago
|
||
Comment on attachment 150500 [details] [diff] [review] Only set <key modifiers> if it's actually needed r=rginda
Attachment #150500 -
Flags: review?(rginda) → review+
|
|
||
Comment 4•20 years ago
|
||
Checked in.
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
|
||
Updated•20 years ago
|
Product: Core → Other Applications
|
||
Updated•6 years ago
|
Product: Other Applications → Other Applications Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•