224737 - [FIX] thumbnails on browse.deviantart.com aren't spaced out

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Jesse Ruderman]

1. Load http://browse.deviantart.com/
Expected: spaced-out images.
Result: images are all on the left side, and there's a big gap at the right.

This regressed between the 11/03 and 11/04 official Firebird builds.

No testcase yet, guessing Layout:Block&Inline because the links seem to have
shrunk vertically too.

Comment 1

[Jesse Ruderman]

Originally reported at http://forums.mozillazine.org/viewtopic.php?t=33124.

Comment 2

[Mats Palmgren (inactive)]

This is a regression from bug 224188

Comment 3

[Mats Palmgren (inactive)]

Attachment: Testcase

Comment 4

[Mats Palmgren (inactive)]

-    if (GetToken(aErrorCode, PR_TRUE)) {
-      if ((eCSSToken_Symbol == mToken.mType) && 
-          (('+' == mToken.mSymbol) || ('>' == mToken.mSymbol))) {

+    if (eCSSToken_Symbol == mToken.mType && 
+        ('+' == mToken.mSymbol) || ('>' == mToken.mSymbol)) {


Umm, someone needs to read his K&R again... ;-)

Comment 5

[Brendan Eich [:brendan]]

Overparenthesizing the == expressions just helps add paren-noise, hiding the
lack of needed parens around the || expression, to make it the right operand of
&&.  Where is that code from?
 
/be

Comment 6

[Mats Palmgren (inactive)]

That was from the patch in bug 224188, which only changed one file:
content/html/style/src/nsCSSParser.cpp

Comment 7

[Mats Palmgren (inactive)]

Attachment: Patch rev. 1

Comment 8

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 134814 [details] [diff] [review]
Patch rev. 1

r+sr=bzbarsky.	The code was overparenthesized, and I deparenthesized it
incorrectly...

Comment 9

[Boris Zbarsky [:bzbarsky]]

To Mats.

Comment 10

[Boris Zbarsky [:bzbarsky]]

Fix checked in (and testcase added to regression tests).  Thanks for the patch,
Mats!