224867 - [FIX]resource:///res/samples/test0.html warnings/errors

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P3)

Description

[Martin Mokrejs]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030826
Build Identifier: 

This is what I get in debug window on Tru64Unxi 5.1A with mozilla 20031105 snapshot:

frame: Text(0) (1414e6190) style: 1414e62a0 :-moz-non-element {}
Wrong parent style context:  style: 1414e6250 :first-letter {}
should be using:  style: 14138ffd0 :first-letter {}

frame: Letter(0) (1414e61f0) style: 1414e6250 :first-letter {}
Wrong parent style context:  style: 1414e5dd8 :first-line {}
should be using:  style: 14136c4c8 {}

Document resource:///res/samples/test0.html loaded successfully


Reproducible: Always

Steps to Reproduce:
1.
2.
3.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Bug 217225 fixes the second warning there.  The first is due to applying
first-letter and first-line to the same element; not sure yet where it's coming
from.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: Proposed patch

The idea here is that we set the reparented style context on the frame before
reparenting the kids.  That way, when the integrity checks are done on the kids
they will return the right things (since the parent of the style context will
in fact equal the style context of the parent; without this change that's not
the case).

Comment 3

[Boris Zbarsky [:bzbarsky]]

Taking.

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 134960 [details] [diff] [review]
Proposed patch

(At some point we should fix the bug on making ReParentStyleContext use
GetParentStyleContextFrame.)

Comment 5

[Boris Zbarsky [:bzbarsky]]

Checked in.