224929 - Focus issues with Java applets

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[Mike Kaply [:mkaply]]

We have been encountering some new focus issues with Java applets.

We tracked them down to the fact that when a window with a plugin is activated,
we don't get a focus change because the java plugin is a frame.

Fix is to post a focus changed message when the frame gets a WM_ACTIVATE - note
this is similar to what we did in Netscape 4.61 to emulate windows focus behavior.

This also allows me to remove a hack fix we put in 1.4.1 to do an extra
NS_GOTFOCUS when we got activated.

Comment 1

[Mike Kaply [:mkaply]]

Attachment: Fix for problem

Comment 2

[Mike Kaply [:mkaply]]

Attachment: Better fix

Don't use the WM_USER hack

Note because this is the 1.4.1 version, it shows us removing the 1.4.1 specific
hack.

Comment 3

[jhp (no longer active)]

Mike, is that last patch your very latest fix, or have you made changes since?

Comment 4

[Mike Kaply [:mkaply]]

Attachment: Trunk fix

This is the trunk version

Comment 5

[Mike Kaply [:mkaply]]

Comment on attachment 134986 [details] [diff] [review]
Better fix

r=pedemont
sr=blizzard
a=mkaply for 1.4.2

Comment 6

[Mike Kaply [:mkaply]]

Comment on attachment 137600 [details] [diff] [review]
Trunk fix

r=pedemont, sr=blizzard (platform specific)
a=mkaply

Comment 7

[Mike Kaply [:mkaply]]

fix checked in