224999 - Build error with "disable-installer"

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Frederic Bezies]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6a) Gecko/20031106 Firebird/0.7+ (Gcc 3.3.1 i686 optimized - MozJF)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6a) Gecko/20031106 Firebird/0.7+ (Gcc 3.3.1 i686 optimized - MozJF)

All is in the title.

Current CVS trunk build.

But the weird point : I set --disable-installer option on :(

Using MingW32 gcc under windows.

Reproducible: Always

Steps to Reproduce:
1.keep your sources up to date
2.make -f client.mk build with mingw32
3.wait

Actual Results:  
build process is broken while making installer ?!



Expected Results:  
Making build process going to its normal end.

Weird point : I did not want to use installer.

Here is my mozconfig :

CC=gcc
CXX=g++
CPP=cpp
AS=as
LD=ld
LDFLAGS=-mwindows

export MOZ_PHOENIX=1
mk_add_options MOZ_PHOENIX=1

ac_add_options --disable-ldap
ac_add_options --disable-mailnews
ac_add_options
--enable-extensions=cookie,xml-rpc,xmlextras,p3p,pref,transformiix,universalchardet,typeaheadfind,webservices
ac_add_options --enable-crypto
ac_add_options --disable-composer
ac_add_options --disable-profilesharing
ac_add_options --disable-installer

mk_add_options MOZ_OBJDIR=@TOPSRCDIR@/../fbbuild

ac_add_options --disable-accessibility
ac_add_options --disable-debug
ac_add_options --disable-tests

ac_add_options --enable-strip
ac_add_options --enable-strip-libs

ac_add_options --enable-optimize="-Os -march=i686"
ac_add_options --enable-reorder
ac_add_options --disable-pedantic

Comment 1

[Frederic Bezies]

A work around has been found by a member of mozillazine forum, in this thread :

http://forums.mozillazine.org/viewtopic.php?t=33768

It seems like you must add in toolkit/mozapps/installer/ a makefile with :


export:

libs: 

So can this workaround be added in some ways ?

Comment 2

[Frederic Bezies]

I forget to say it seems to break linux building process
(http://forums.mozillazine.org/viewtopic.php?t=33783) too :(

Comment 3

[Asa Dotzler [:asa]]

Ben, can you take a look at this?

Comment 4

[Brian Ryner (not reading)]

I checked in a fix for the two problems pointed out in the forum posts:

- added the installer makefiles to allmakefiles.sh
- made it not build the installer if --disable-installer was given

Comment 5

[Steffen Wilberg]

Building without "disable-installer" works.
Building with "disable-installer" fails. -> reopening.

LINK : warning LNK4044: unrecognized option '/L../../dist/lib/components'; ignored
   Creating library MozillaFirebird.lib and object MozillaFirebird.exp
nsStaticComponents.obj : error LNK2019: unresolved external symbol "struct
nsModuleInfo nsJarModule_gModuleInfo"
(?nsJarModule_gModuleInfo@@3UnsModuleInfo@@A) referenced in function
_nsJarModule_NSGetmodule
MozillaFirebird.exe : fatal error LNK1120: 1 unresolved externals
make[4]: *** [MozillaFirebird.exe] Error 96
make[4]: Leaving directory `/cygdrive/g/mozilla/mozilla/browser/app'
make[3]: *** [libs] Error 2
make[3]: Leaving directory `/cygdrive/g/mozilla/mozilla/browser'
make[2]: *** [tier_99] Error 2
make[2]: Leaving directory `/cygdrive/g/mozilla/mozilla'
make[1]: *** [default] Error 2
make[1]: Leaving directory `/cygdrive/g/mozilla/mozilla'
make: *** [build] Error 2

Comment 6

[Frederic Bezies]

What ?!

Here is what gives me my latest about:buildconfig (today's build, and cvs
sources up-to-date at midnight mozilla.org time)

Build platform

target
i686-pc-cygwin

Build tools

Compiler 	Version 	Compiler flags

$(CYGWIN_WRAPPER) gcc -mno-cygwin 	gcc version 3.3.1 (mingw special
20030804-1) 	-Wall -W -Wno-unused -Wpointer-arith -Wcast-align -Wno-long-long
-mms-bitfields -pipe

$(CYGWIN_WRAPPER) g++ -mno-cygwin 	gcc version 3.3.1 (mingw special
20030804-1) 	-fno-rtti -fno-exceptions -Wall -Wconversion -Wpointer-arith
-Wcast-align -Woverloaded-virtual -Wsynth -Wno-ctor-dtor-privacy -Wno-long-long
-mms-bitfields -pipe


Configure arguments
--disable-ldap --disable-mailnews
--enable-extensions=cookie,xml-rpc,xmlextras,p3p,pref,transformiix,universalchardet,typeaheadfind,webservices
--enable-crypto --disable-composer --disable-profilesharing --disable-installer
--disable-accessibility --disable-debug --disable-tests --enable-strip
--enable-strip-libs '--enable-optimize=-Os -march=i686' --enable-reorder
--disable-pedantic

And my User-Agent :

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6b) Gecko/20031108
Firebird/0.7+ (Gcc 3.3.1 i686 optimized - MozJF)

There is something wrong with your source... Are you sure they're up-to date ?

Comment 7

[Steffen Wilberg]

My source was (and is) up-to-date.
I first built with "disable-installer". It resulted in the error I mentioned in
comment 5.
I then built from the same source without "disable-installer", i.e. I commented
out that line with an "#". It worked fine. I should've mentioned that I don't
use gcc but .net 2003.

Build ID: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6a)
Gecko/20031108 Firebird/0.7+ (Steffen).

about:buildconfig

Build platform
target
i586-pc-msvc

Build tools
Compiler 	Version 	Compiler flags
$(CYGWIN_WRAPPER) cl 	13.10.3077 for 80x86 	-TC -nologo -W3 -nologo -Gy
-Fd$(PDBFILE)
$(CYGWIN_WRAPPER) cl 	13.10.3077 for 80x86 	-TP -nologo -W3 -nologo -Gy
-Fd$(PDBFILE)

Configure arguments
--disable-ldap --disable-mailnews
--enable-extensions=cookie,xml-rpc,xmlextras,p3p,pref,transformiix,universalchardet,typeaheadfind,webservices
--enable-crypto --disable-composer --disable-profilesharing --disable-tests
--disable-debug '--enable-optimize=-Oxs -G7 -arch:SSE' --disable-shared
--enable-static

Comment 8

[Frederic Bezies]

I should have bet it :)

Try removing --enable-static and --disable-shared in your .mozconfig :)

Comment 9

[Steffen Wilberg]

I build with --enable-static and --disable-shared since weeks. It works with MSVC.

But I have a strange feeling that I should do a make clean after modifying my
mozconfig. I'm trying it again...

Comment 10

[Steffen Wilberg]

It worked with a "make -f client.mk clean" before building.

Is it recommended or obligatory to make clean after modifying your mozconfig?

Comment 11

[Frederic Bezies]

The best thing to do is to get mozilla/firebird/thunderbird build in a directory
outside trunk directory, using :

mk_add_options MOZ_OBJDIR=@TOPSRCDIR@/../fbbuild.

It keeps trunk sources clean. :)

Comment 12

[Brian Ryner (not reading)]

I suspect the problem is that building without the installer changes libjar from
a dynamic component to a static one, but you may have both of them in dist/lib.
 Does anything change if you remove the dist directory and re-run make from the top?

Comment 13

[Steffen Wilberg]

Sorry for the delay, I had some problems building yesterday.
No, deleting the dist directory didn't help.

I checked out and built successfully without "disable-installer".
I then deleted the dist dir (but did not "make clean") and built again from the
same source with "disable-installer".
I got the same error I mentioned in comment 5.

Comment 14

[Simon Paquet [:sipaq]]

Does not qualify for blocker severity.

Comment 15

[cls]

Removing the dist directory wouldn't be enough as the libjar will not be
rebuilt.  (The fact that libjar is built differently when the installer is
present should be a bug itself. ) When changing configure options, a 'make
distclean' between builds is recommended and sometimes, like this, required.