225150 - remove ununused setter/getter in overrideHandler.js

Status: RESOLVED FIXED

(Core Graveyard :: File Handling, defect)

Description

[Pierre Chanial]

the setters/getter 'smallIconURL' and 'largeIconURL' are not used in the
codebase. While I was at it, I notice that the class .file-icon-large isn't used
neither, so that we can eventually cvs remove the files content-large.gif and
content-small.gif to your appreciation.

Comment 1

[Pierre Chanial]

Attachment: patch v1.0

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 135133 [details] [diff] [review]
patch v1.0

r=me (except the phoenix part because I'm no peer there, but I guess you don't
need review for that anyway)

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 135133 [details] [diff] [review]
patch v1.0

sr=bzbarsky

Comment 4

[Pierre Chanial]

Whao... the file handling task force in action... :)
should I cvs remove the files content-small.gif and content-large.gif?

Comment 5

[Boris Zbarsky [:bzbarsky]]

If they are not used elsewhere, yes.  I see no reason to keep them, and if we
really need them later Attic is there.

Comment 6

[Christian :Biesinger (don't email me, ping me on IRC)]

yes, I agree

Comment 7

[Pierre Chanial]

the FHTF strikes back... :)
these icons aren't used.

Comment 8

[Pierre Chanial]

fixed.