Closed
Bug 225203
Opened 21 years ago
Closed 21 years ago
Weird AddRef/Release pair if AddCookieToList fails
Categories
(Core :: Networking: Cookies, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: caillon, Assigned: caillon)
Details
Attachments
(1 file)
|
3.31 KB,
patch
|
dwitte
:
review+
jst
:
superreview+
|
Details | Diff | Splinter Review |
After an IRC conversation with dwitte, we decided to move the addref after the
failure check so as to save an addref/release pair in the failure case. The one
caller which passed in a 0-refcounted object needs to be updated to manually
delete its object, which is more explicit about its failure measures. Having a
method "magically" delete your objects on failure is a bit odd :)
|
Assignee | |
Comment 1•21 years ago
|
||
|
|
Assignee | |
Updated•21 years ago
|
Attachment #135167 -
Flags: review?(dwitte)
|
|
||
Comment 2•21 years ago
|
||
Comment on attachment 135167 [details] [diff] [review]
Patch
ace in the hole!
Attachment #135167 -
Flags: review?(dwitte) → review+
|
|
Assignee | |
Updated•21 years ago
|
Attachment #135167 -
Flags: superreview?(jst)
|
||
Comment 3•21 years ago
|
||
Comment on attachment 135167 [details] [diff] [review]
Patch
Heh, ok :-)
sr=jst
Attachment #135167 -
Flags: superreview?(jst) → superreview+
|
|
Assignee | |
Comment 4•21 years ago
|
||
Checked in.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•