225245 - image shown as attachment instead of inline if the cid uses single quotes

Status: VERIFIED FIXED

(MailNews Core :: MIME, defect)

Description

[Alfonso Martinez]

This is just another case where an image isn't shown inside an HTML but instead
as an attachment, similar to bug 61815, bug 131618 and bug 154836

the example mail has two images, the first one is single quoted and isn't shown
in  Mozilla, the second one uses double quotes and display properly, just this code:

Single quoted img: <img src=3D'cid:Incr000'><br>
double quoted img: <img src=3D"cid:Incr001"><br>

mozilla 2003 10 28 04, winXP

Comment 1

[Alfonso Martinez]

Attachment: Mail showing the problem

just a simple test case

Comment 2

[Klaus S. Madsen]

*** Bug 243286 has been marked as a duplicate of this bug. ***

Comment 3

[timeless]

Attachment: scan for " or '

Comment 4

[David :Bienvenu]

Comment on attachment 148281 [details] [diff] [review]
scan for " or '

For future maintainability, could you change the name of the var, since you've
changed the meaning of it? I suggest quoteDelimiter. sr=bienvenu with that
change. I'll let Ducarroz have a peak at this too.

Comment 5

[Jean-Francois Ducarroz]

Comment on attachment 148281 [details] [diff] [review]
scan for " or '

Good catch. As requested by David, please rename the isquote variable, maybe
hasDelimiter or just delimiter!
R=ducarroz

Comment 6

[Mike Cowperthwaite]

How extensive is that parser's domain?  Does it only affect reading attributes 
on an HTML tag, or does it also apply to (e.g.) MIME headers?  (See bug 129285 
comment 5.)

Comment 7

[Ben Bucksch (:BenB)]

Because I thought only double quotes were allowed in HTML attributes, and I just
learned better:
<quote src="http://www.w3.org/TR/REC-html40/intro/sgmltut.html#h-3.2.2">
By default, SGML requires that all attribute values be delimited using either
double quotation marks (ASCII decimal 34) or single quotation marks (ASCII
decimal 39).
</quote>

Comment 8

[Mike Cowperthwaite]

(In reply to comment #7)
> Because I thought only double quotes were allowed in HTML attributes [...]

Was that intended as an answer to my comment 6?  It doesn't quite.

Comment 9

[Ben Bucksch (:BenB)]

No, unrelated. I didn't know and shared the spec in case somebody else were as
confosed as me.

Comment 10

[timeless]

Comment on attachment 148281 [details] [diff] [review]
scan for " or '

mozilla/mailnews/mime/src/mimemrel.cpp	 1.38

Comment 11

[Mike Cowperthwaite]

timeless, what happened with this bug?  Was that attachment checked in?  If so,  
why was it obsoleted?

Comment 12

[Mike Cowperthwaite]

Verifying fixed.  I still don't know why timeless marked the patch obsolete.

Comment 13

[Mike Cowperthwaite]

*** Bug 254449 has been marked as a duplicate of this bug. ***

Comment 14

[Mike Cowperthwaite]

Comment on attachment 148281 [details] [diff] [review]
scan for " or '

I just noticed my old test-case message for this was displaying incorrectly in
TB 0.8.

Comment 15

[Mike Cowperthwaite]

(In reply to comment #14)
> I just noticed my old test-case message for this was displaying incorrectly in
> TB 0.8.

... only when displaying as Original HTML.  Simple HTML properly handles both 
sorts of quotes.

Comment 16

[Asa Dotzler [:asa]]

Comment on attachment 148281 [details] [diff] [review]
scan for " or '

a=asa for aviary checkin.

Comment 17

[Mike Cowperthwaite]

*** Bug 312289 has been marked as a duplicate of this bug. ***