Closed
Bug 225260
Opened 21 years ago
Closed 21 years ago
Link NSPR dynamic shared libraries with the -headerpad_max_install_names option
Categories
(NSPR :: NSPR, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
4.4.1
People
(Reporter: wtc, Assigned: wtc)
Details
Attachments
(1 file)
|
766 bytes,
patch
|
ccarlen
:
review+
sfraser_bugs
:
superreview+
|
Details | Diff | Splinter Review |
We should link the NSPR dynamic shared libraries with the -headerpad_max_install_names linker option so that their install names can be changed with install_name_tool. See the ld(1) man page on Mac OS X for documentation on -headerpad_max_install_names.
|
Assignee | |
Comment 1•21 years ago
|
||
Note that $(DSO_LDOPTS) is passed to the compiler $(CC) in the MKSHLIB command, but it seems that I don't need to use "-Wl," in front of -headerpad_max_install_names.
|
|
Assignee | |
Updated•21 years ago
|
Attachment #135199 -
Flags: superreview?(sfraser)
Attachment #135199 -
Flags: review?(ccarlen)
|
||
Comment 2•21 years ago
|
||
Comment on attachment 135199 [details] [diff] [review] Proposed patch second time lucky i guess
Attachment #135199 -
Flags: superreview?(sfraser) → superreview+
|
||
Comment 3•21 years ago
|
||
Comment on attachment 135199 [details] [diff] [review] Proposed patch r=ccarlen
Attachment #135199 -
Flags: review?(ccarlen) → review+
|
|
Assignee | |
Comment 4•21 years ago
|
||
Patch checked into the NSPR tip (NSPR 4.5), NSPR_4_4_BRANCH (NSPR 4.4.1), and NSPR_PRE_4_2_CLIENT_BRANCH (Mozilla 1.6 Beta).
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Target Milestone: --- → 4.4.1
You need to log in
before you can comment on or make changes to this bug.
Description
•