225269 - Can't use a bookmark as my homepage

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect)

Description

[Andrew Benton]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6b) Gecko/20031110 Firebird/0.7+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6b) Gecko/20031110 Firebird/0.7+

When I go to Tools> Options> General and click on Use Bookmark for my home page,
I choose the site I want and click OK but the Home Page doesn't change. I get
this on Windows XP and Mandrake 9.1 Linux. I have to open the page in the
browser and click Use Current Page. That works.

Reproducible: Always

Steps to Reproduce:
1.Go to Tool> Options> General
2.Click Use Bookmark for your homepage
3.Choose a bookmark

Actual Results:  
Nothing Changed

Expected Results:  
Used the bookmark

Comment 1

[Ali Ebrahim]

Confirming on Windows & Linux. Setting to All/All, as there's no reason to
suspect that it wouldn't occur on MacOS X as well.

Comment 2

[Oleg Sidletskiy]

*** Bug 227200 has been marked as a duplicate of this bug. ***

Comment 3

[Peter van der Woude [:Peter6]]

Can't you guys rename some of the bug descriptions. It is impossible to find one
back if things are called at random. Keywords make you find those bugnr's.
My dupe bug 
[Bug 227200] Options - General - homepage - Use Bookmarks does not work

is at least easy to find with a query.
Ask "Bookmarks" and you get 50.000 bugs posted :-(((((
it is not even posted under Menu, but preferences.

Please change those bug descriptions if they are vague or malformed or malposted
(wrong section).

Most of us struggle enough to post it right but that doesn't make us experts !

Comment 4

[Mike Connor [:mconnor]]

js console is clean, I'll poke this later

Comment 5

[Jesse Ruderman]

Peter: what did you search for that you didn't find this bug?  A search for
"Bookmark home page" finds it, and I don't see any other useful keywords in your
bug's summary.

Comment 6

[Oleg Sidletskiy]

for me, just clicking "Use Bookmark..." button produces following errors in JS
console (but I have enabled non-default JS warnings/errors with TTLO):

Error: selection.protocol has no properties
Source File: chrome://browser/content/bookmarks/selectBookmark.js
Line: 30

Warning: reference to undefined property selection.protocol
Source File: chrome://browser/content/bookmarks/selectBookmark.js
Line: 30

(first > last sort order)

Comment 7

[Oleg Sidletskiy]

actually it's first Warning then Error, I think.

Comment 8

[PikeUK]

In bookmarksTree.xml all references to protocol are commented out with this note
(added by pch in revision 1.47):
//protocol broken since we have unique ID...

Commenting out the protocol references in selectBookmark.js as well makes this
feature work again.

Comment 9

[Andrew Benton]

Confirmed. Commenting out the reference to selection.protocol in
selectBookmark.js works. I can now use a bookmark to set my home page.

Comment 10

[Mike Connor [:mconnor]]

good catch!  I'll attach a patch tonight so it'll get done before 0.8

plussing blocking request since its a regression that we can easily fix

Comment 11

[Mike Connor [:mconnor]]

Attachment: patch to comment out protocol references

per pch's comments in the other bug.  Only a comment out since that's all pch
did in the other locations, not sure what his plans are

Comment 12

[Mike Connor [:mconnor]]

Comment on attachment 136791 [details] [diff] [review]
patch to comment out protocol references

provisionally to pch, but ben, if you see this, please just take a look, its
just a simple patch

Comment 13

[PikeUK]

I may be way off here, but should this line (from a few lines below the patch):

  protocol = child.Value.split(":")[0];

now have a var prefixed to it since the original declaration has been commented
out, else protocol will be created as a global?

Comment 14

[Mike Connor [:mconnor]]

Attachment: patch v2

oops, right-o

Comment 15

[Steffen Wilberg]

Comment on attachment 136795 [details] [diff] [review]
patch v2

>+// xxx - protocal is broken since we have unique id...
>+// xxx - protocal is broken since we have unique id..
"protocol", not "protocal". And you forgot the third dot :)

Comment 16

[Pierre Chanial]

fixed.

Comment 17

[Mike Connor [:mconnor]]

sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs,
filter on "beltznerLovesGoats" to get rid of this mass change