225281 - checkbox label background problem on the "Install Complete" page

Status: VERIFIED FIXED

(Firefox :: Installer, defect, P2)

Description

[Sunil Garg]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6b) Gecko/20031110 Firebird/0.7+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6b) Gecko/20031110 Firebird/0.7+

on the "install complete" page, there is a gray background behind "ird 0.7 now."
and the rest of the field following it

Reproducible: Always

Steps to Reproduce:
1. Open firebirdsetup.exe
2. run through the install (I've done it both over a seb-installed copy, and a
fresh copy)
3. look at the "install complete" page



Expected Results:  
it should have a white background like the rest of the frame in the window

Comment 1

[Sunil Garg]

Attachment: screenshot (XP)

Comment 2

[Simon Paquet [:sipaq]]

Confirming on 2003-11-10 build on WinXP.
I use a 1024x768 resolution.

Comment 3

[Simon Paquet [:sipaq]]

Ups, really confirming. Ths is also happening on a 1152x864 resolution.

Comment 4

[Max Spicer]

Confirming on XP with firefox 0.8.  Doesn't happen on 2000 according to sipaq.

Comment 5

[Mike Goodspeed]

I've also got this problem (just on my computer... none other).  Reporter (  	
sunil?) does your installer go horridly slow?  Mine does, and then I get this
bug at the end of the installer.

Comment 6

[José Jeria]

With:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7b) Gecko/20040317
Firefox/0.8.0+

this looks even worse, since the background is orange now.

Comment 7

[José Jeria]

Attachment: Orange background

Comment 8

[Sunil Garg]

The installer took about 50 seconds for me on the "Installing..." page.

Also, for me, the last page didn't have an orange background, but what seemed
like a mask uncovering a repeat of the logo on the left of the window
(screenshot is next up)

Comment 9

[Sunil Garg]

Attachment: new screenshot

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7b) Gecko/20040318
Firefox/0.8

Comment 10

[José Jeria]

*** Bug 242432 has been marked as a duplicate of this bug. ***

Comment 11

[Mike Goodspeed]

I'm having the same problems as comment 8 and for what it's worth, am having the
same problems with the thunderbird installer.

Comment 12

[Ben Goodger (use ben at mozilla dot org for email)]

This is going to suck. but +ing.

Comment 13

[Christopher Seaman]

same problem as listed.

might be worthwhile to note that the discoloration changes after the window is 
dragged offscreen.

bizaare

Comment 14

[José Jeria]

*** Bug 246034 has been marked as a duplicate of this bug. ***

Comment 15

[Ben Goodger (use ben at mozilla dot org for email)]

If someone knows how to fix this, please try. I've spent hours so far and can't
figure out what's causing it. 

Comment 16

[Tim Meader]

Ben, not sure that this helps in any way... but it would appear as though the
portion that always gets displayed behind the text is a part of the Firefox logo
that is NOT shown on the left. It's almost as if the truncated portions of the
logo are "overflowing" for lack of a better term.

Comment 17

[Chris Vance]

(In reply to comment #16)
> Ben, not sure that this helps in any way... but it would appear as though the
> portion that always gets displayed behind the text is a part of the Firefox logo
> that is NOT shown on the left. It's almost as if the truncated portions of the
> logo are "overflowing" for lack of a better term.

I disagree.  I have seen artifacts that appear to belong to portions of the
FireFox logo that are displayed.  However, when I took a screenshot, the
artifact shown changed.

As mentioned in Comment#13, the discoloration will change when the window is
dragged offscreen, released, then dragged back onscreen.

Worth noting is that the artifacts are only displayed in the portion of the
screen behind the "Launch Firefox now" text, and only behind the clickable
elements of that line (to toggle the checkbox).

This was seen with 0.9 RC and full 0.9 Windows releases.

Comment 18

[Chris Vance]

I should mention that the background only appears automatically for me when the
install window is to the left side of the screen.  When I move the install
window to the right side of the screen, and the final screen appears (which
shows this bug), I do not see the background stuff this bug discusses.

To the best of my knowledge, the same behavior occurs when moving the window
offscreen on the bottom-right side of the screen - no background stuff should
appear.  Background stuff will appear behind the text, however, when the install
window is moved offscreen and then back onscreen in other spots (like off both
the right and left edges of the screen.

I can only offer wild speculation as to why this is occurring.

Comment 19

[Brodie]

I can consistently get redraw problems if I move the window very quickly using
the mouse. The window must go off screen and then bring it back on again.
Sometimes the artifacts will show on the left half of the checkbox string, but
when mousing over it, it changes to a different artifact on the right side of
the checkbox. It only ever seems to show up in the checkbox and associated
string area.

Comment 20

[Brodie]

Attachment: various effects

SS showing a few various effects from moving the window around. All from
Windows XP.

Comment 21

[Kevin Stange]

This bug exists in the installer for Thunderbird as well.  Should that be filed
as a separate bug?

Comment 22

[Robert Pendell]

I have noticed this bug too for quite some time.  It took a while before it made
it to the list on the Firefox build postings though.  This has been a bug for
every nightly build on both Firefox and Thunderbird for as long as I can
remember.  Occasionally it does not happen but that is really very rare.  One
install out of every 100 i'd say.

Comment 23

[PikeUK]

Does removing WS_EX_TRANSPARENT from this line make any difference?

http://lxr.mozilla.org/seamonkey/source/toolkit/mozapps/installer/windows/wizard/setuprsc/setuprsc.rc#370

Comment 24

[Tim Meader]

You know, the transparency could very well have something to do with it.

I just installed Firefox on about 5 different Windows 98 machines (thus no
transparency) and NONE of those installs manifested this problem. It occurs to
some degree every time I install Firefox on an XP machine.

Comment 25

[Jack]

Confirming comment #24.  This bug is most definitely transparency/Windows XP 
related.  Using the installer on both Windows 98 Second Edition and Windows 
2000 Professional Service Pack Four shows no problems, which is understandable 
as neither have transparency.

Comment 26

[Robert Parenton]

Windows 2000 does support transparency.

Comment 27

[Tim Meader]

Yes, that is incorrect, Windows 2000 does indeed support transperancy. Though,
honestly, I cannot see what possible harm it would do to try out the suggestion
in comment #23.

I'd be happy to whip up the patch if it seems likely.

Comment 28

[Eugene Savitsky]

I suggest to remove the final logo and see if that helps. The same problem
appears in Thunderbird, but with blue color (thunderbird's logo color...)

I bet on that it is part/copy of big logo.

Comment 29

[PikeUK]

*** Bug 250720 has been marked as a duplicate of this bug. ***

Comment 30

[Grey Nicholson (they/them)]

This hasn't been explicitly mentioned above: moving the Install window causes a
different part of the logo to show up when the window is released. It doesn't
appear as if the logo is remaining stationary and the checkbox "window" moving
across it.

As a cheap workaround, why not get rid of the checkbox and just have two buttons?
[Finish] [Start Firefox Now]

Comment 31

[Snap]

I have this bug with the Firefox 0.9.3 installer and Thunderbird 0.7.3 installer
(bug 250907) too.
1152x864 but Windows XP shows me Normal size: 96dpi

Comment 32

[Mike Wills]

This seems to have been fixed in the 20040810 installer build from yesterday.

Comment 33

[Max Spicer]

I've just installed the 20040811 full setup builds of firefox and thunderbird
and definitely observed this bug in the thunderbird build, and am 90% certain it
was in the firefox build.

Comment 34

[Ross Shannon]

I just installed the latest Sunbird build, 0.2, and this problem did not occur
(on WinXP). Might be worth looking into any differences there are between the
images that are being displayed in these two installers, specifically the size
of the image.

It always seems to be a part of the image that is cropped out of view on the
left that gets tiled again underneath the checkbox. If this image was cropped to
the minimum dimensions needed to display in that bar on the side, it may not
repeat again under that part.

Comment 35

[Mike Wills]

I haven't had this problem for quite a while in the nightly "aviary" Firefox
builds. I am running Windows 2000 SP4 and Windows XP SP2.

Comment 36

[Peter van der Woude [:Peter6]]

Is bug 257565 the same issue (see attached animation there)
Dupe that one if it is please

Comment 37

[Adam Hansen]

This bug is only present on my workstation when using Windows XP "Luna".  I 
can not duplicate this usings Windows XP "Classic".

Comment 38

[Peter]

Attachment: Screenshot from Firefox 1.0 Preview Release installer on Windows XP SP2

Screenshot attached is from running the Firefox 1.0 Preview Release installer
on Windows XP SP2.

Mozilla/5.0 (Windows; U; Windows NT 5.1; rv:1.7.3) Gecko/20040913 Firefox/0.10

Comment 39

[Ryan Polk (Quark)]

We don't need anymore screenshots of this bug.  The developers know what's
happening, they just haven't had the time to figure out the why yet.

Comment 40

[Bill Mason]

*** Bug 259430 has been marked as a duplicate of this bug. ***

Comment 41

[Ali Ebrahim]

*** Bug 260344 has been marked as a duplicate of this bug. ***

Comment 42

[Ben Goodger (use ben at mozilla dot org for email)]

Grumble. Not a "blocker"

Comment 43

[Unknown W. Brackets]

(In reply to comment #42)
> Grumble. Not a "blocker"

In that case, perhaps the checkbox could just be removed for 1.0?  It looks a
lot worse to have something like that in the installer, than not to have a
checkbox to automatically start firefox.

-[Unknown]

Comment 44

[Will Ryan]

(In reply to comment #43)
> In that case, perhaps the checkbox could just be removed for 1.0?  It looks a
> lot worse to have something like that in the installer, than not to have a
> checkbox to automatically start firefox.

I'd have to agree with Unknown. Sometimes prevention is better than cure.

Comment 45

[Ryan Polk (Quark)]

*** Bug 261994 has been marked as a duplicate of this bug. ***

Comment 46

[Ryan Polk (Quark)]

*** Bug 262311 has been marked as a duplicate of this bug. ***

Comment 47

[Ing-Long Eric Kuo]

(In reply to comment #23)
> Does removing WS_EX_TRANSPARENT from this line make any difference?
> 
http://lxr.mozilla.org/seamonkey/source/toolkit/mozapps/installer/windows/wizar
d/setuprsc/setuprsc.rc#370

That may help, but this line is wrong, it should read 'DIALOG DISCARDABLE' 
instead of 'DIALOGEX'.
http://lxr.mozilla.org/seamonkey/source/toolkit/mozapps/installer/windows/wizar
d/setuprsc/setuprsc.rc#362

-eric@[removethis]frontmotion.com

Comment 48

[Tim Meader]

I haven't seen an occurrence of this in over 10 installs now. Is it possible
this was fixed by something else?

Anyone else still seeing this behavior in an aviary nightly installer build?

Comment 49

[sairuh (rarely reading bugmail)]

yes, I'm still seeing this with the 2004100412-0.9 firefox (branch) bits on
winXPsp2.

Comment 50

[Unknown W. Brackets]

(In reply to comment #48)
> I haven't seen an occurrence of this in over 10 installs now. Is it possible
> this was fixed by something else?
> 
> Anyone else still seeing this behavior in an aviary nightly installer build?

Are you using Windows Classic?  It has been reported that this happens only on
XP with a theme other than Classic in use. (see comment #37)

I would argue that while there are many power-users who use Windows Classic,
grandmothers who use Windows XP almost all use its default theme... which makes
this fairly high visibility, if this is true, no?

-[Unknown]

Comment 51

[Keith Gable]

can still reproduce on a two day old nightly, XP SP1, Microsoft Royale theme

dialup, but I'll re-download the latest-1.0 and test.

Comment 52

[Bill Gianopoulos [:WG9s]]

OK I have a suggestion here.  It appears that there is a textbox or something
surrounding the checkbox text.  The reason I think that, is that the area that
appears selectable extends far to the right of the actual text.

Would it be possible to try just having the text there without the surrounding
selectable area?  Another idea would be to make the text not select the checkbox
but require clicking on the box itself to select/deselect the option to see if
either of these makes the bad display issue disapear?

I realize this has been minused as a blocker, but I think that was more because
we had no clue how to fix it than because it was not thought important enough to
try to fix.

The reason I still think this is important to fix is that we are trying to
convince IE people that when Firefox displays a page differnetly than IE it is
not necessarily that Firefox is incorrect in it's behavior.

It is kind of hard to make that arguement it if it can't even display it's own
installer windows correctly.

Comment 53

[Bill Gianopoulos [:WG9s]]

I just did a fresh Firefox and Thunderbird install and looked at the piece of
the image being displayed over the text more closely, and noticed something that
I had not noticed before.  It appears that the piece of the image that displays
over the text is not, as I had thought previously, a part of the image that is
displayed on the left.  It is actualy a part of the image that is NOT displayed
on the left becuase the bottom of the image is clipped becuase it is too large
to fit in the area where it is being displayed.

This leads me to wonder if a workaround could be as simple as just creating a
new image file with the image cropped to be just what will be displayed, rather
than having the image be bigger and rely on the program logic to correctly crop
the image?

Comment 54

[Tracy Walker [:tracy]]

As of 10/08 builds this is double ugly with the addition of the homepage
checkbox to the Install Complete dialog. (bug 262593)

Comment 55

[Bill Gianopoulos [:WG9s]]

Er.  I think you meant bug 262953.

Comment 56

[Bill Gianopoulos [:WG9s]]

OK. I have done a bit more folling around with this and I am pretty sure that as
a workaround for this issue if the checkbox labels were just made to not be
checkbox labels, but just text positioned to the right of the textbox, that
would eliminate the rendering issue.  The reason I suspect hat is that the area
effected but eh misplaced image pieces is the same area that is selectable to
check the box.

The only downside of this is that it changes the operation such that you must
click on the checkbox itself to change the option.  Clicking on the text would
no longer have any effect.

If I still had a system set up to do builds, I would try to make a patch to do this.

Comment 57

[Kevin Stange]

I'm no expert on accessibility, and I don't know if the accessibility of the
installer has even been planned for, but I would say that disassociating the
labels with the checkbox would make it impossible for screen readers and other
accessibility tools to tell the user what they have selected, which would be
less than ideal.

Comment 58

[Ross Shannon]

William, not to discourage you, but don't spend your time writing a patch that
makes the label unfocusable. It won't be checked in, for the reasons Kevin just
mentioned.

Comment 59

[Keith Gable]

Attachment: Installer image cropped at exact width

This image is cropped to fit in the box. If it is a problem with the installer
doing the cropping itself, this will fix it.

Comment 60

[Andrew Pattison]

I would just like to add that I am seeing this problem also, although it only
shows up when I have themes turned on in Windows XP. If themes are disabled then
this problem disappears.

I will attach a screen show showing the same problem on the latest nightly build
of Firefox.

Comment 61

[Andrew Pattison]

Attachment: Screen shot showing problem on latest nightly build

Comment 62

[Will Ryan]

Andrew, read the other comments before replying, please. As commenter #39 said,
"We don't need anymore screenshots of this bug.  The developers know what's
happening, they just haven't had the time to figure out the why yet."

It saves the devs the trouble of having overcrowded bugs and numerous pics of
the same problem. I'm not trying to be rude, so I hope I don't come off that
way, I've made the same mistake too :)

Comment 63

[Son Le]

I've been googling and it looks like this is a bug with XP visual themes and
checkboxes and track bars. I've tried removing WS_EX_TRANSPARENT, changing
'DIALOGEX' to 'DIALOG DISCARDABLE' and using image cropped to exact width and
nothing has worked.

There's a few suggested fixes on Google that subclass the checkbox and override
the WM_CTLCOLORBTN message. However, because we're using PropertySheets, this
message is not being passed thru to the subclass. :(

Comment 64

[Keith Gable]

Well, I've got a question: is there any reason in particular that you're not
using NSIS? It supports LZMA (7-Zip's compression). If there's no reason, I
wouldn't mind converting the Firefox installer to NSIS format. Sure, it's a
shotty way around this bug,  but it'd fix it. And it might run slightly faster
too (for me, this installer is pretty slow to respond, and slow to operate).

Comment 65

[Brian Adams]

Yeah, why isn't the Mozilla installer just packaged with NSIS?  I think it would
be a better installer anyways, even if this problem wasn't around.

Comment 66

[Brian Adams]

Yeah, why isn't the Mozilla installer just packaged with NSIS?  I think it would
be a better installer anyways, even if this problem wasn't around.

Comment 67

[Keith Gable]

Yeah, same here. I could almost completely clone the current installer in NSIS.
The component selection screen might be slightly different, but everything else
is possible. The downside is that the installer won't work on Linux or OSX
(which the current one does, I think).

Comment 68

[Son Le]

Attachment: remove PSH_WATERMARK feature from dialog setup wizard

It turns out that the watermark feature of the setup wizard was responsible for
the checkbox problem and my inability to trap the WM_CTLCOLOR messages.
Removing the watermark allowed me to control the background of the text, but
meant I had to reimplement some of its features.

This patch does all the work. The only risky part is the _WIN32_IE redefinition
from 0x0400 to 0x0500 which was need to get the header background to appear in
white. However, some of the PSH_xx definitions used in the source are from the
later version so I think the risk is low.

The new Header.bmp needs to be 50x50, otherwise it won't show up. I created one
from the old Header.bmp, but feel free to come up with a better one. Also the
Watermrk.bmp can be cropped to 500x315 as that's all that is currently being
used.

Comment 69

[Son Le]

Attachment: New Header.bmp that is 50x50

Comment 70

[Bill Gianopoulos [:WG9s]]

Would this not also require a new header bmp for Thunderbird as well then?

Comment 71

[Son Le]

(In reply to comment #70)
> Would this not also require a new header bmp for Thunderbird as well then?

I'm not familiar with Thunderbird, but the header bmp is in a firefox
sub-directory. If there is a separate Thunderbird header bmp, then it would also
need to be made as 50x50, otherwise the setup dialog header would be all white
(ie. no logo).

Comment 72

[Bill Gianopoulos [:WG9s]]

Well that was kind of my point.  If the approach of this patch is accepted, it
would not be approved for checkin unless a 50x50 header.bmp is provided for
Thunderbird, because checking this in as provided will break the Tunderbird
installer.

Comment 73

[Son Le]

Attachment: New unofficial Header.bmp

Comment 74

[Son Le]

Attachment: New Thunderbird Header.bmp

Comment 75

[Son Le]

(In reply to comment #72)

Point taken. I have attached the header bmp for Thunderbird and the unofficial
builds. Strictly speaking none of the bitmaps are 50x50 as they don't look too
good at that size so I've kept them at 63x50, 60x50 and 61x50. The installer
will only take the first 50x50 and ignore the rest. The same goes for the
watermark (500x315) so there's a potentially 1mb (uncompressed) savings there.

Comment 76

[Bill Gianopoulos [:WG9s]]

Great!  Actually I was about to make those other 2 myself.

Comment 77

[Tim Meader]

Please don't set a bug to "?" that has already been set to "-", especially ones
that Ben has set to "-".

If you wish to get this in, and I agree it is VERY important, please try to get
a review and sr and then get it admitted through asking the devs, etc. They are
normally quite helpful on IRC as well (#firefox channel).

Comment 78

[Asaf Romano (gone)]

reasking for blocking-1.0, there was no patch here when ben removed blocking1.0+

Comment 79

[Ben Goodger (use ben at mozilla dot org for email)]

I applied this patch and for some reason the headers in the intermediate pages
are grey, with no logo. I may be ok with this however. 

Comment 80

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 161659 [details] [diff] [review]
remove PSH_WATERMARK feature from dialog setup wizard

r+a=[e-mail]

Comment 81

[Ben Goodger (use ben at mozilla dot org for email)]

OK, I've noted the grey background on the header problem... if you can fix it it
would be great but I've already landed your fix here (sans header graphics since
as I said they don't show up)... since I think the grey header problem is less
of a problem than the garbled checkboxes. Please file a new bug if you get a
fix, and plus it for 1.0 blocking. Thanks a lot!

Comment 82

[Bill Gianopoulos [:WG9s]]

I thought the issue of the header Icons not showing up was what the new
header.bmp files were supposed to fix.  See comment #68.

Comment 83

[Asaf Romano (gone)]

Looking at the chekin, it doesn't seem you landed the new image files.

Comment 84

[Justin Wood (:Callek)]

mostafah, does this affect Sunbird's installer (and do we need our own Header.bmp)

Comment 85

[Asa Dotzler [:asa]]

Ben said he's aware that the images weren't checked in and that was because they
weren't functional so there wasn't a point in checking them in (yet). Hopefully
he'll add comments here when he gets free again.

Comment 86

[Son Le]

Attachment: New flags for wizard97 (fixes grey header)

It seems like the PrSht.h header on the build machine is an older version that
doesn't contain the newer definition of PSH_WIZARD97 based on _WIN32_IE. 

This patch adds the required definition to the dialogs.c file.

Comment 87

[Fareed Rizkalla]

Has anyone checked if it is an installer problem.
Some bad design flaw in the program that creates the installer.

Or is the installer home made.

Comment 88

[Hussam Al-Tayeb]

(In reply to comment #87)
> Has anyone checked if it is an installer problem.
> Some bad design flaw in the program that creates the installer.
> 
> Or is the installer home made.

AFAIK, it is home made. the installer is made by mozilla.

Comment 89

[Ben Goodger (use ben at mozilla dot org for email)]

I'll post a revised patch here in just a moment with the final changes required. 

Comment 90

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: patch

The changes proposed by attachment 162281 [details] [diff] [review] need to go *after* the #include
<PrSht> ... this patch does this.

Comment 91

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: new Header.bmp from Steve Garrity.

Comment 92

[Ben Goodger (use ben at mozilla dot org for email)]

OK... new Header.bmp and patch checked in... for official builds and as far as
1.0 is concerned this is done. Please address any new issues in separate bug
reports. 

Comment 93

[Tracy Walker [:tracy]]

verified with Windows branch build 2004-10-18-07-0.9

Comment 94

[Scott MacGregor]

around the time this change went in, I stopped seeing the thunderbird header
image in the installer. Is this because we didn't check in a corresponding
Header.bmp for Thunderbird?

Comment 95

[Steven Garrity [:sgarrity]]

Attachment: Updated Thunderbird header.bmp

Scott, here's the equivalent Thunderbird header.

Comment 96

[Scott MacGregor]

Thanks Steven! I just checked in this new artwork. Hopefully that will fix the
problem in tomorrow's builds. 

Comment 97

[Simon Paquet [:sipaq]]

*** Bug 267449 has been marked as a duplicate of this bug. ***