225301 - cmsutil test program IGNORES BAD SIGNATURES

Status: RESOLVED FIXED

(NSS :: Tools, defect, P1)

Description

[Nelson Bolyard (seldom reads bugmail)]

When our cmsutil QA program decodes a signed message (or detached signature),
it completely ignores whether the signature is good or bad.  It outputs
the same output and returns the same program status whether the signature
was correct or incorrect.   It's USELESS for validating signatures, and 
it's worse than useless as a QA regression tool.  

I will fix this pronto.

Comment 1

[Nelson Bolyard (seldom reads bugmail)]

Marking P1 for NSS 3.9, and accepting bug.

Comment 2

[Nelson Bolyard (seldom reads bugmail)]

Attachment: patch v1

This patch does the following:
1. Fixes the Usage message to document the command line options.
2. Changes the "decode" function to
   a) report an error on bad signatures, only when decoding the input file,
      not when decoding an ancillary "enveloped file".
   b) only output the contents of the "detached content" file (-c option)
      when that file's content was actually used in the computation.
3. Sundry other cleanup and added comments.

Comment 3

[Nelson Bolyard (seldom reads bugmail)]

Comment on attachment 135287 [details] [diff] [review]
patch v1

Please review.
I just spotted the misspelling of "envelope". :(

Comment 4

[Wan-Teh Chang]

Comment on attachment 135287 [details] [diff] [review]
patch v1

This patch has two problems.

1. The SECU_FileToItem(&sitem, decodeOptions->contentFile) was
moved inside a for loop.  We should not read the content file
repeatedly.

2. The new code

>+	SECItem *item = (sitem.len && sitem.data) 
>+	                    ? &sitem 
>+	                    : NSS_CMSMessage_GetContent(cmsg);

may not handle a zero-length content file correctly.

Comment 5

[Nelson Bolyard (seldom reads bugmail)]

Attachment: patch v2

This patch incorporates Wan-Teh's review comments.

Comment 6

[Nelson Bolyard (seldom reads bugmail)]

Checking in cmsutil.c;
/cvsroot/mozilla/security/nss/cmd/smimetools/cmsutil.c,v  <--  cmsutil.c
new revision: 1.44; previous revision: 1.43