225328 - <toolbar.xml> code cleanup

Status: RESOLVED FIXED

(SeaMonkey :: General, defect)

Description

[Serge Gautherie (:sgautherie)]

User-Agent:       Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.6a) Gecko/20031030
Build Identifier: Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.6a) Gecko/20031030

The purpose of this bug is not to fix a specific misbehaviour,
it's only to review patch(s) to improve the code somewhat.


Reproducible: Always

Steps to Reproduce:

Comment 1

[Serge Gautherie (:sgautherie)]

Attachment: (Av1_w) Unused 'XUL_NS' removal

(This 'diff -w' patch is to help review, not for check in.)

Comment 2

[Serge Gautherie (:sgautherie)]

Attachment: (Av1) Unused 'XUL_NS' removal

(patch coming from bug 195241 attachment 135198 [details] [diff] [review])

*Removes unused 'XUL_NS'.
*Adds a comment on empty 'catch' block.
*Adds parenthesis in 2 '() ? :' lines, to ease reading.
*(white space trimming)

Comment 3

[Serge Gautherie (:sgautherie)]

Comment on attachment 135253 [details] [diff] [review]
(Av1) Unused 'XUL_NS' removal


Use attachment 135252 [details] [diff] [review] to ease review.

Comment 4

[Serge Gautherie (:sgautherie)]

Attachment: (Av2) Unused 'XUL_NS' removal [Checked in: Comment 9]

Comment 5

[[e-mail]]

Comment on attachment 136752 [details] [diff] [review]
(Av2) Unused 'XUL_NS' removal
[Checked in: Comment 9]

>-
You didn't really mean to delete this, did you?

Comment 6

[Alec Flett]

Comment on attachment 136752 [details] [diff] [review]
(Av2) Unused 'XUL_NS' removal
[Checked in: Comment 9]

sr=alecf

Comment 7

[Serge Gautherie (:sgautherie)]

Comment on attachment 136752 [details] [diff] [review]
(Av2) Unused 'XUL_NS' removal
[Checked in: Comment 9]


'approval1.6=?': Trivial unused code removal.
(if not too late)

Comment 8

[chris hofmann]

Comment on attachment 136752 [details] [diff] [review]
(Av2) Unused 'XUL_NS' removal
[Checked in: Comment 9]

this should go into the trunk for 1.7

Comment 9

[Serge Gautherie (:sgautherie)]

Comment on attachment 136752 [details] [diff] [review]
(Av2) Unused 'XUL_NS' removal
[Checked in: Comment 9]


Checked in by { 1.29	neil%parkwaycc.co.uk	Dec 20 09:52 }