Closed
Bug 225400
Opened 21 years ago
Closed 21 years ago
Leaking 2 string bundles in nsAccessNode
Categories
(Core :: Disability Access APIs, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: caillon, Assigned: caillon)
Details
(Keywords: memory-leak)
Attachments
(1 file)
|
12.55 KB,
patch
|
timeless
:
review+
jst
:
superreview+
|
Details | Diff | Splinter Review |
181 stringBundleService->CreateBundle(ACCESSIBLE_BUNDLE_URL,
182 &gStringBundle);
183 NS_IF_ADDREF(gStringBundle);
184 stringBundleService->CreateBundle(PLATFORM_KEYS_BUNDLE_URL,
185 &gKeyStringBundle);
186 NS_IF_ADDREF(gKeyStringBundle);
This patch also includes some fun random cleanup that I was doing anyway:
- gets rid of nsIPref in favor of non-deprecated interfaces.
- makes the hashtables members rather than pointers
|
Assignee | |
Comment 1•21 years ago
|
||
Comment on attachment 135296 [details] [diff] [review]
Patch
static NS_DEFINE_CID(kStringBundleServiceCID, NS_STRINGBUNDLESERVICE_CID);
please replace this CID w/ a contract. CIDs should only be used within a module
Attachment #135296 -
Flags: review+
|
|
Assignee | |
Updated•21 years ago
|
Attachment #135296 -
Flags: superreview?(jst)
|
|
Assignee | |
Comment 3•21 years ago
|
||
This also fixes a leak of an nsInterfaceHashtable which got nullstomped but
never deleted.
|
||
Comment 4•21 years ago
|
||
Comment on attachment 135296 [details] [diff] [review]
Patch
sr=jst
Attachment #135296 -
Flags: superreview?(jst) → superreview+
|
|
Assignee | |
Comment 5•21 years ago
|
||
Checked in.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•