225424 - The View/Apply Theme menu of available themes should be sorted alphabetically

Status: RESOLVED FIXED

(Core Graveyard :: Skinability, enhancement)

Description

[Ilka Stromberg]

User-Agent:       Mozilla/5.0 (Windows; U; Win 9x 4.90; en-US; rv:1.5) Gecko/20031007
Build Identifier: Mozilla/5.0 (Windows; U; Win 9x 4.90; en-US; rv:1.5) Gecko/20031007

The  View/Apply Theme  menu of available themes should be sorted alphabetically.

In this day an age any "list"  should be sorted in some sort of sequence so that
what the user is looking for can be found quickly.


Reproducible: Always

Steps to Reproduce:
1.
2.
3.

Comment 1

[Jon Henry]

Confirmed. To be more specific, both the View > Apply Theme menu and the Themes
preferences panel are in the same, arbitrary order (other than Classic always
being first). As an example, here's the menu as it appears now on my machine, I
just grabbed some random themes to test with.

Classic
American 1.5b
Modern
Toy Factory 1.5b+
Pinball

Comment 2

[Malcolm Rowe]

-> me (I have a patch, will attach in a few hours)

Comment 3

[Malcolm Rowe]

Attachment: Sort the theme names in the View/Apply and preferences windows

Comment 4

[Malcolm Rowe]

Comment on attachment 135465 [details] [diff] [review]
Sort the theme names in the View/Apply and preferences windows

Requesting review. There's a similar change in Firebird, but I'll attach that
to a separate bug.

Comment 5

[Malcolm Rowe]

(The Firebird bug is bug 225669.)

Comment 6

[[e-mail]]

Comment on attachment 135465 [details] [diff] [review]
Sort the theme names in the View/Apply and preferences windows

>-          <menupopup id="theme" datasources="rdf:chrome" ref="urn:mozilla:skin:root" oncommand="applyTheme(event.target)" onpopupshowing="checkTheme()">
>+          <menupopup id="theme" datasources="rdf:chrome" ref="urn:mozilla:skin:root" oncommand="applyTheme(event.target)" onpopupshowing="checkTheme()"
>+                     sortResource="http://www.mozilla.org/rdf/chrome#displayName"
>+                     sortDirection="ascending">
Although you were wise enough not to tack your attributes onto the end of this
overlong line it would have been nice if you could have rewrapped the line
while you were editing it ;-)

Comment 7

[Alec Flett]

Comment on attachment 135465 [details] [diff] [review]
Sort the theme names in the View/Apply and preferences windows

sr=alecf

Comment 8

[Jon Henry]

Should we ask for 1.5b approval on this? I imagine it's pretty low-risk.

Comment 9

[Jon Henry]

Obviously I meant 1.6b, sorry for the spam.

Comment 10

[Asa Dotzler [:asa]]

Comment on attachment 135465 [details] [diff] [review]
Sort the theme names in the View/Apply and preferences windows

a=asa (on behalf of drivers) for checkin to 1.6 beta.

Comment 11

[Darin Fisher]

patch checked in