225570 - nsMsgCompose carefully avoids using GetTypeFromFile

Status: RESOLVED FIXED

(MailNews Core :: Composition, defect)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

In nsMsgCompose::ProcessSignature:
the code has an nsILocalFile to work with
but, it gets the nativePath from it, inits a filespec with it, then CIs a
nsIFileURL, inits it with the native path, gets the extension from that, and
asks the mimeservice for the type.

it should simply ask the mimeservice for the type of the nsILocalFile. (using
the GetTypeFromFile method)

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: something like this

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 135402 [details] [diff] [review]
something like this

r=bzbarsky

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

Checking in mailnews/compose/src/nsMsgCompose.cpp;
/cvsroot/mozilla/mailnews/compose/src/nsMsgCompose.cpp,v  <--  nsMsgCompose.cpp
new revision: 1.412; previous revision: 1.411
done

Comment 4

[Aleksey Nogin]

This checkin have added a "may be used uninitialized" warning on brad TBox:

+mailnews/compose/src/nsMsgCompose.cpp:3320
+ `nsresult rv' might be used uninitialized in this function

Indeed, if identity is NULL on line 3348, then on line 3385, it will try testing
NS_FAILED on an unitialized rv - see
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/mailnews/compose/src/nsMsgCompose.cpp&rev=1.412&mark=3348,3385#3320

Should I file a new bug for this or reopen this one?

Comment 5

[Boris Zbarsky [:bzbarsky]]

Fix checked in for the warning.