225641 - Installer should ask where to put icons

Status: VERIFIED FIXED

(Firefox :: Installer, defect, P3)

Description

[alanjstr]

The installer created shortcuts in the Start Menu, QuickLaunch toolbar, and on
the deskop.  One would have been sufficient.  Firebird should ask where to
create shortcuts.

Comment 1

[Jason Barnabe (np)]

Bug 28174 is the Seamonkey version of this bug.

Comment 2

[alanjstr]

This includes asking whether the icons are for All Users or for the currently
logged in user.  If someone installs the application into a directory that only
they can access, for example.  

Comment 3

[alanjstr]

*** Bug 230734 has been marked as a duplicate of this bug. ***

Comment 4

[Travis Chase]

*** Bug 228809 has been marked as a duplicate of this bug. ***

Comment 5

[Max Spicer]

I think conversion is a bit of an overstatement.  How does having deleteable
icons placed on the desktop/startmenu stop people using Firefox?  IE puts them
there, afterall.  I agree that there should be an option (I don't want them
there either), but disagree with the conversion keyword.

Comment 6

[David Tenser [:djst]]

From the Designed for Windows XP Application Specification:

"F1.1 Install shortcuts correctly

The Start menu is designed to give users easy access to launch applications.
Usability studies show that when the Start menu and/or Windows Desktop become
too cluttered, users have a very difficult time finding and launching their
programs. This leads to a bad user experience.

* Do not place shortcuts on the Desktop except by request of the user. If an
option to add such a shortcut is offered to the user, then this should not be
checked by default. Automatic installs should not place any shortcuts on the
Desktop. 

[...]

* Do not place shortcuts to documents, such as Readme files, in the Start menu.
If you have important information that the user should see, consider displaying
that information during the install process or on the help menu of the application."

Comment 7

[Ben Goodger (use ben at mozilla dot org for email)]

+ing to see if I can find an easy way of doing this. Will take a patch!

Comment 8

[Ben Goodger (use ben at mozilla dot org for email)]

OK I know how to do this

1) add a new page to the installer (custom path only)
2) page contains checkboxes for Desktop, Quick Launch and Start Menu
3) checkboxes set registry keys for current user
4) browser.jst reads these keys to determine what shortcuts to create. 

Comment 9

[David Tenser [:djst]]

(In reply to comment #8)
> OK I know how to do this
> 
> 1) add a new page to the installer (custom path only)
> 2) page contains checkboxes for Desktop, Quick Launch and Start Menu

And the Desktop checkbox should not be checked by default, as explained in
comment 6.

Comment 10

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: partial progress

This re-enables the "Windows Integration" page for custom installs, and
populates the checkboxes with values, but doesn't do anything yet.

Stage 2 (tomorrow): have these things set registry keys, and make the installer
scripts read those keys before creating shortcuts.

Comment 11

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: it's alive!

Comment 12

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: do this for tbird too

Comment 13

[Ben Goodger (use ben at mozilla dot org for email)]

Fixed branch and trunk

Comment 14

[Bill Mason]

Verified fixed on trunk, 20040602 PC/Win2K

Comment 15

[Tom Metro]

FYI for anyone looking for an update on the issue of icons created by the
installer...although this bug is closed, the problem lives on in bug 245392.