225653 - Can we eliminate ConvertMessagesToResourceArray? (Appears unused)

Status: RESOLVED FIXED

(MailNews Core :: Backend, defect)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

ConvertMessagesToResourceArray _appears_ unused (no callers that I can see)

http://lxr.mozilla.org/seamonkey/search?string=ConvertMessagesToRe

http://lxr.mozilla.org/seamonkey/source/mailnews/base/resources/content/mailCommands.js#38

 38 function ConvertMessagesToResourceArray(messages,  resourceArray)
 39 {
 40     dump("fix or remove this\n");
 41     // going away...
 42 }

David, Scott, Neil, can we safely remove this?

Comment 1

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Patch to remove it, if my assumption rings true.

Comment 2

[[e-mail]]

Comment on attachment 135461 [details] [diff] [review]
Patch to remove it, if my assumption rings true.

Sure, sounds like a hangover from when the thread pane used RDF.

Comment 3

[Stephen Donner [:stephend] Not actively reading bugmail]

Comment on attachment 135461 [details] [diff] [review]
Patch to remove it, if my assumption rings true.

Trying a different super-reviewer.

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

C:\moz_src\mozilla\mailnews\base\resources\content>cvs commit -m "Bug 225653.  R
emove unused function ConvertMessagesToResourceArray().  r=neil, sr=bienvenu" ma
ilCommands.js
Checking in mailCommands.js;
/cvsroot/mozilla/mailnews/base/resources/content/mailCommands.js,v  <--  mailCom
mands.js
new revision: 1.78; previous revision: 1.77
done