225819 - <no_space.xul>: Remove it and convert profile migrator to use prompt service

Status: RESOLVED FIXED

(Core Graveyard :: Profile: Migration, defect)

Description

[Serge Gautherie (:sgautherie)]

User-Agent:       Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.6a) Gecko/20031030
Build Identifier: Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.6a) Gecko/20031030

Moved from bug 195241 comment 7.

See bug 197315 comment 1 !


Reproducible: Always

Steps to Reproduce:

Comment 1

[Serge Gautherie (:sgautherie)]

Reassigning from '[e-mail]' to me :-)

Comment 2

[Serge Gautherie (:sgautherie)]

Attachment: Initial display (v0)

How the window looked before I began.

(I'm using Windows classic theme.)

Comment 3

[Serge Gautherie (:sgautherie)]

Attachment: New display (v1)

Moved:
*Icon: right -> left.
*Buttons: left -> center.

Somehow, height and width increased...

Comment 4

[Serge Gautherie (:sgautherie)]

Comment on attachment 135583 [details]
New display (v1)


I would prefer if the second text would start on the right of the icon too;
but I don't want to learn layout skill just yet:

helpwanted !
Or shall we just leave it as is, and move to r/sr process yet ?

Comment 5

[[e-mail]]

Sorry for wasting your time, but it occurs to me that this dialog is unnecessary;
the work could be done using commonDialog.xul instead.

Comment 6

[[e-mail]]

Attachment: Proposed patch

Comment 7

[Serge Gautherie (:sgautherie)]

Addition to comment 4:

I believe that the use of the '!' icon should be replaced by a '?' icon too.
(I don't know what the Prompt Service version looks like.)

Comment 8

[[e-mail]]

Good point; our prompt service currently always uses ? for confirmEx.

Comment 9

[Conrad Carlen (not reading bugmail)]

Comment on attachment 135597 [details] [diff] [review]
Proposed patch

r=ccarlen

Comment 10

[[e-mail]]

Fix checked in.