225878 - Server name for Movemail accounts spuriously hidden

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[Stefan Borggraefe]

Regression from bug 222940. The cause for this bug is that the function
hideShowControls() hides the enclosing container instead the element itself when
the element doesn't have the attribute iscontrolcontainer="true".

Comment 1

[Stefan Borggraefe]

Attachment: Patch

Comment 2

[[e-mail]]

Comment on attachment 135646 [details] [diff] [review]
Patch

Would it be possible to remove all occurrences of iscontrolcontainer and
hidable and simply put hidefor on the control containers?
document.getElementsByAttribute("hidefor", "*") would help. Otherwise at least
remove iscontrolcontainer="true" from that hbox.

Comment 3

[Stefan Borggraefe]

Attachment: Simplify the way the controls are hidden.

> Would it be possible to remove all occurrences of iscontrolcontainer and
> hidable and simply put hidefor on the control containers?

This was actually what I did at first. But then I thought the patch was getting
a bit large for this small bug and I wasn't sure if I missed the point of the
(IMHO overdone) function to hide the controls.

But since you are positive about this change, here is the patch. :-)

The Offline & Diskspace pane uses the same code. With my patch this bad
smelling duplicate code is avoided.

Comment 4

[[e-mail]]

Comment on attachment 135792 [details] [diff] [review]
Simplify the way the controls are hidden.

Hey, you're getting good at this ;-)

Comment 5

[Stefan Borggraefe]

Checked in by timeless. Marking FIXED.